Skip to content

Improve testsuite #45792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Improve testsuite #45792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
([ -d "$COMPOSER_HOME" ] || mkdir "$COMPOSER_HOME") && cp .github/composer-config.json "$COMPOSER_HOME/config.json"

echo COLUMNS=120 >> $GITHUB_ENV
echo PHPUNIT="$(pwd)/phpunit --exclude-group tty,benchmark,intl-data" >> $GITHUB_ENV
echo PHPUNIT="$(pwd)/phpunit --exclude-group tty,benchmark,intl-data,integration" >> $GITHUB_ENV
echo COMPOSER_UP='composer update --no-progress --ansi' >> $GITHUB_ENV

SYMFONY_VERSIONS=$(git ls-remote -q --heads | cut -f2 | grep -o '/[1-9][0-9]*\.[0-9].*' | sort -V)
Expand Down
4 changes: 3 additions & 1 deletion src/Symfony/Component/Lock/Tests/Store/CombinedStoreTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@

/**
* @author Jérémy Derussé <jeremy@derusse.com>
* @group integration
*/
class CombinedStoreTest extends AbstractStoreTest
{
Expand All @@ -41,7 +42,8 @@ protected function getClockDelay()
*/
public function getStore(): PersistingStoreInterface
{
$redis = new \Predis\Client(array_combine(['host', 'port'], explode(':', getenv('REDIS_HOST')) + [1 => null]));
$redis = new \Predis\Client(array_combine(['host', 'port'], explode(':', getenv('REDIS_HOST')) + [1 => 6379]));

try {
$redis->connect();
} catch (\Exception $e) {
Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Component/Lock/Tests/Store/PdoStoreTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
* @author Jérémy Derussé <jeremy@derusse.com>
*
* @requires extension pdo_sqlite
* @group integration
*/
class PdoStoreTest extends AbstractStoreTest
{
Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Component/Lock/Tests/Store/ZookeeperStoreTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
* @author Ganesh Chandrasekaran <gchandrasekaran@wayfair.com>
*
* @requires extension zookeeper
* @group integration
*/
class ZookeeperStoreTest extends AbstractStoreTest
{
Expand Down