[4.4] [Yaml] dumper fix and refactor #47167
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3380a9f to
4734e34
Compare
4734e34 to
3fe7570
Compare
|
The refactoring should happen (if we decide that's necessary) on |
|
So we need to change this into a "fix only" branch. |
|
Yes please |
|
Up to finish this PR @donquixote? |
|
yes, I will take the time soon :) |
|
this will be finished in #48331, thank you for starting the work on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #46731 to 4.4.
Check individual commits when reviewing!
The idea is that every commit should have a passing test.