[6.0] [Yaml] Restore two failing test methods in DumperTest. #47168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike in 4.4, in 6.0 these failing calls throw exceptions.
cef730f to
b6aeb79
Compare
|
We'd better merge the PR fixing these issues rather than merging "expected failures". |
I like a strategy where we document known issues as tests with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods were lost in merge commit 8752c8b - too bad we can't show a direct diff between two commits for a single file in github.
The test methods document the misbehavior as known issues. They will be changed when the failing behavior is fixed in #46731.
(I personally think this is a good way to write tests in preparation for a fix)
Unlike in 4.4, in 6.0 these failing calls throw exceptions.
This should be a preparation for #46731, or before merging #47167 to 6.0.