Skip to content

Replace get_class() calls by ::class #47401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

deguif
Copy link
Contributor

@deguif deguif commented Aug 26, 2022

Q A
Branch? 6.2
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

Replace get_class() by ::class

@stof
Copy link
Member

stof commented Aug 26, 2022

I'm really not convinced that $object::class is more readable than get_class($object). I would be in favor of keeping the usage of get_class

@deguif deguif force-pushed the get_class_to_class_keyword-cs-rule branch from 7bf01b2 to 32eded8 Compare August 26, 2022 15:16
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Aug 26, 2022

I like the change personally. It gives a consistent syntax to get the class of something. Once used to it, we won't want to get back :)

@fabpot fabpot force-pushed the get_class_to_class_keyword-cs-rule branch from 32eded8 to 675601b Compare September 1, 2022 02:03
@fabpot
Copy link
Member

fabpot commented Sep 1, 2022

Thank you @deguif.

@fabpot fabpot merged commit 0be39ad into symfony:6.2 Sep 1, 2022
@deguif deguif deleted the get_class_to_class_keyword-cs-rule branch September 1, 2022 03:51
PhilETaylor pushed a commit to PhilETaylor/symfony that referenced this pull request Sep 6, 2023
This PR was squashed before being merged into the 6.2 branch.

Discussion
----------

Replace get_class() calls by ::class

| Q             | A
| ------------- | ---
| Branch?       | 6.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Replace `get_class()` by `::class`

Commits
-------

675601b Replace get_class() calls by ::class
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request May 29, 2025
This PR was merged into the 6.4 branch.

Discussion
----------

Replace `get_class()` calls by `::class`

This change was made in symfony codebase in 2022 symfony/symfony#47401.

I think we can use same rule in our examples

Commits
-------

65599c4 Replace get_class() calls by ::class
nicolas-grekas added a commit that referenced this pull request May 30, 2025
This PR was merged into the 7.4 branch.

Discussion
----------

Replace `get_class()` calls by `::class`

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->
| License       | MIT

Replace `get_class()` by `::class`
It was already done in past in #47401

Commits
-------

e0a602b Replace get_class() calls by ::class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants