-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Replace get_class() calls by ::class #47401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
requested changes
Aug 26, 2022
I'm really not convinced that |
7bf01b2
to
32eded8
Compare
I like the change personally. It gives a consistent syntax to get the class of something. Once used to it, we won't want to get back :) |
derrabus
approved these changes
Aug 26, 2022
chalasr
approved these changes
Aug 30, 2022
artyuum
approved these changes
Aug 31, 2022
32eded8
to
675601b
Compare
Thank you @deguif. |
PhilETaylor
pushed a commit
to PhilETaylor/symfony
that referenced
this pull request
Sep 6, 2023
This PR was squashed before being merged into the 6.2 branch. Discussion ---------- Replace get_class() calls by ::class | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Replace `get_class()` by `::class` Commits ------- 675601b Replace get_class() calls by ::class
This was referenced May 29, 2025
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
May 29, 2025
This PR was merged into the 6.4 branch. Discussion ---------- Replace `get_class()` calls by `::class` This change was made in symfony codebase in 2022 symfony/symfony#47401. I think we can use same rule in our examples Commits ------- 65599c4 Replace get_class() calls by ::class
nicolas-grekas
added a commit
that referenced
this pull request
May 30, 2025
This PR was merged into the 7.4 branch. Discussion ---------- Replace `get_class()` calls by `::class` | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT Replace `get_class()` by `::class` It was already done in past in #47401 Commits ------- e0a602b Replace get_class() calls by ::class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
get_class()
by::class