Skip to content

Replace get_class() calls by ::class #21016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

Replace get_class() calls by ::class #21016

merged 1 commit into from
May 29, 2025
+9 −9

Conversation

alamirault
Copy link
Contributor

This change was made in symfony codebase in 2022 symfony/symfony#47401.

I think we can use same rule in our examples

@alamirault alamirault requested a review from xabbuh as a code owner May 29, 2025 12:08
@carsonbot carsonbot added this to the 7.3 milestone May 29, 2025
@alamirault alamirault changed the base branch from 7.3 to 6.4 May 29, 2025 12:10
@alamirault alamirault changed the title Replace get_class() calls by ::class Replace get_class() calls by ::class May 29, 2025
@javiereguiluz javiereguiluz modified the milestones: 7.3, 6.4 May 29, 2025
@javiereguiluz
Copy link
Member

javiereguiluz commented May 29, 2025 •
edited
Loading

I like this. Simpler and more modern! Thanks Antoine.

@javiereguiluz javiereguiluz merged commit 3d83f8d into symfony:6.4 May 29, 2025
4 of 6 checks passed
@alamirault alamirault deleted the feature/sf-47401 branch May 30, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@alamirault @javiereguiluz @carsonbot