Move the new Security helper to the root of SecurityBundle #47760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Oct 1, 2022
There was a problem hiding this comment.
👍 Should make @javiereguiluz happy as he was challenging that redundancy issue when the class was introduced :)
Haha, I vaguely remembered this discussion, but couldn't find it anywhere. I believe I was against this change back then, but seeing the class name in the docs changed my mind :) |
xabbuh
approved these changes
Oct 2, 2022
|
Thank you @wouterj. |
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Oct 22, 2022
…lper namespace (smnandre) This PR was merged into the 6.2 branch. Discussion ---------- [Security] Fix the SecurityBundle\Security.php helper namespace This PR fix the new `Security` helper namespace change introduced by this PR: symfony/symfony#47760 (itself following symfony#17284) Targeting 6.2 because the Security Helper class did not exists there before Commits ------- f1467e7 Fix the Security\Helper namespace
chalasr
added a commit
that referenced
this pull request
Dec 9, 2022
…nstants (IonBazan) This PR was merged into the 6.2 branch. Discussion ---------- [Security] Fix invalid deprecation messages in Security constants | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This PR changes invalid deprecation message, suggesting to use `\Symfony\Bundle\SecurityBundle\Security::ACCESS_DENIED_ERROR` instead of `\Symfony\Component\Security\Core\Security::ACCESS_DENIED_ERROR`, while `\Symfony\Component\Security\Http\SecurityRequestAttributes::ACCESS_DENIED_ERROR` should be used. For reference: #47760 Commits ------- 3fd5a40 Point `Security::*` constants to `SecurityRequestAttributes::*` ones
fabpot
added a commit
to fabpot/rector-symfony
that referenced
this pull request
Dec 21, 2022
This class has been moved in symfony/symfony#47760
samsonasik
pushed a commit
to rectorphp/rector-symfony
that referenced
this pull request
Dec 21, 2022
This class has been moved in symfony/symfony#47760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While merging symfony/symfony-docs#17284 , I found this rather repeating FQCN:
...\SecurityBundle\Security\Security. Security is important, but let's move the class (also introduced in 6.2) one level up to make the FQCN not unnecessarily long.