Skip to content

[Security] Add documentation for programmatic login #17284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2022

Conversation

johnkrovitch
Copy link
Contributor

Add documentation for programmatic login

Fixes #16940

@OskarStark
Copy link
Contributor

friendly ping @chalasr for a review

@OskarStark OskarStark requested a review from wouterj September 21, 2022 15:00
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good to me, the feature is well covered. I think this needs some rephrasing/reorganization though

@OskarStark
Copy link
Contributor

Thank you Robin!

@johnkrovitch johnkrovitch force-pushed the docs/programmatic-login branch from bdf6b93 to 062f9a4 Compare September 21, 2022 22:09
@johnkrovitch
Copy link
Contributor Author

Thank you very much for your reviews. Changes have been made.

@johnkrovitch johnkrovitch requested review from OskarStark and chalasr and removed request for wouterj and OskarStark September 21, 2022 22:10
@johnkrovitch johnkrovitch force-pushed the docs/programmatic-login branch from 062f9a4 to 64c9c4d Compare September 21, 2022 22:11
@johnkrovitch johnkrovitch force-pushed the docs/programmatic-login branch from cd28724 to 0fb878b Compare September 26, 2022 11:08
@wouterj wouterj force-pushed the docs/programmatic-login branch from 2ae3b43 to b63ccf7 Compare October 1, 2022 16:24
@wouterj
Copy link
Member

wouterj commented Oct 1, 2022

Thank you @johnkrovitch! I've edited your changes a bit, mostly reducing the information of more advanced usages down to a single code example. Very cool to finally have this feature in Symfony :)

@wouterj wouterj merged commit d6e5067 into symfony:6.2 Oct 1, 2022
chalasr added a commit to symfony/symfony that referenced this pull request Oct 2, 2022
…le (wouterj)

This PR was merged into the 6.2 branch.

Discussion
----------

Move the new Security helper to the root of SecurityBundle

| Q             | A
| ------------- | ---
| Branch?       | 6.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

While merging symfony/symfony-docs#17284 , I found this rather repeating FQCN: `...\SecurityBundle\Security\Security`. Security is important, but let's move the class (also introduced in 6.2) one level up to make the FQCN not unnecessarily long.

Commits
-------

472544e Move the new Security helper to the root of SecurityBundle
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Oct 22, 2022
…lper namespace (smnandre)

This PR was merged into the 6.2 branch.

Discussion
----------

[Security] Fix the SecurityBundle\Security.php helper namespace

This PR fix the new `Security` helper namespace change introduced by this PR: symfony/symfony#47760
(itself following symfony#17284)

Targeting 6.2 because the Security Helper class did not exists there before

Commits
-------

f1467e7 Fix the Security\Helper namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security] Add a method in the security helper to ease programmatic login
6 participants