[HttpClient] Make HttplugClient implement PSR-17 factories instead of Httplug's #47832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Oct 11, 2022
4a82c64 to
c8208a4
Compare
stof
reviewed
Oct 11, 2022
c8208a4 to
e8fd26a
Compare
e8fd26a to
c3aa36c
Compare
fabpot
approved these changes
Oct 15, 2022
|
Thank you @nicolas-grekas. |
|
It looks like this added |
Merged
|
FTR, the previous comment was addressed in #47873. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 17, 2023
…(nicolas-grekas) This PR was merged into the 5.4 branch. Discussion ---------- [ErrorHandler] Don't throw deprecations for HttplugClient | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #50035 | License | MIT | Doc PR | - Follows php-http/httplug#171 and #47832 Required to make the CI green again. Commits ------- bafb237 [ErrorHandler] Don't throw deprecations for HttplugClient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nobody uses
php-http/message-factoryanyway:https://packagist.org/packages/php-http/message-factory-implementation/dependents