[HttpClient] TraceableHttpClient: increase decorator's priority #47836
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
fec41fe to
c0c33a3
Compare
|
Got it, we don't care as the http-client collector is not about tracing code execution but requests/responses. |
There was a problem hiding this comment.
This means we have to adjust the decoration priority of RetryableHttpClient as well on higher branches:
which might be more risky BC-wise (see #38633 for background)
1e3f943 to
a4e3b93
Compare
There was a problem hiding this comment.
I set the priority to 5 instead, to account for @chalasr's well spotted comment.
|
Thank you @adpeyre. |
Hello,
When I decorate my http client, all requests are not collected and visible in the profiler because of the decorator's priority of TraceableHttpClient (sub request for example). I think it should be increased. I fixed an arbitrary value of 100.
What do you think about that ?
Ty