-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Console] Update Application.php #47907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
Should this be merged into the |
Do what you think is right. |
Will the error output look differently after this change? If so, can you share before and after screenshots? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM then
@maxbeckers what do you think? |
@xabbuh im also fine with that. 👍 |
@aleksandr-shevchenko can you please submit the PR for 4.4? The code is not exactly the same. |
@nicolas-grekas the difference in 4.4 is from PR #47883 ... so i guess it shoud be rebased to 4.4 and then merged to 4.4? |
yes |
Is anyone willing to submit this change to 4.4? |
I'd do that, but I guess I only could create a new PR with the change. So @aleksandr-shevchenko should do the rebase. |
I did the rebase and switched the target branch to |
Thank you @aleksandr-shevchenko. |
#47862 (comment)