Skip to content

[Console] Update Application.php #47907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Conversation

aleksandr-shevchenko
Copy link
Contributor

@aleksandr-shevchenko aleksandr-shevchenko commented Oct 19, 2022

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

#47862 (comment)

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@xabbuh
Copy link
Member

xabbuh commented Oct 19, 2022

Should this be merged into the 4.4 branch?

@aleksandr-shevchenko
Copy link
Contributor Author

Should this be merged into the 4.4 branch?

Do what you think is right.

@nicolas-grekas nicolas-grekas modified the milestones: 6.2, 4.4 Oct 19, 2022
@carsonbot carsonbot changed the title Update Application.php [Console] Update Application.php Oct 19, 2022
@nicolas-grekas nicolas-grekas changed the base branch from 6.2 to 4.4 October 19, 2022 07:50
@nicolas-grekas nicolas-grekas changed the base branch from 4.4 to 6.2 October 19, 2022 07:50
@xabbuh
Copy link
Member

xabbuh commented Oct 19, 2022

Will the error output look differently after this change? If so, can you share before and after screenshots?

@aleksandr-shevchenko
Copy link
Contributor Author

Will the error output look differently after this change? If so, can you share before and after screenshots?

image

Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then

@xabbuh
Copy link
Member

xabbuh commented Oct 19, 2022

@maxbeckers what do you think?

@maxbeckers
Copy link
Contributor

@xabbuh im also fine with that. 👍

@nicolas-grekas
Copy link
Member

@aleksandr-shevchenko can you please submit the PR for 4.4? The code is not exactly the same.
Please mind the commit message/PR title also since this is going to be used for the changelog.
Thanks.

@maxbeckers
Copy link
Contributor

@nicolas-grekas the difference in 4.4 is from PR #47883 ... so i guess it shoud be rebased to 4.4 and then merged to 4.4?

@nicolas-grekas
Copy link
Member

yes

@fabpot
Copy link
Member

fabpot commented Oct 24, 2022

Is anyone willing to submit this change to 4.4?

@maxbeckers
Copy link
Contributor

I'd do that, but I guess I only could create a new PR with the change. So @aleksandr-shevchenko should do the rebase.

@xabbuh xabbuh changed the base branch from 6.2 to 4.4 October 26, 2022 16:02
@xabbuh
Copy link
Member

xabbuh commented Oct 26, 2022

I did the rebase and switched the target branch to 4.4.

@fabpot
Copy link
Member

fabpot commented Oct 26, 2022

Thank you @aleksandr-shevchenko.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants