Skip to content

[Cache] RedisTrait::createConnection does not pass auth value from redis sentinel cluster DSN #48711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2022
Merged

[Cache] RedisTrait::createConnection does not pass auth value from redis sentinel cluster DSN #48711

merged 1 commit into from
Dec 22, 2022

Conversation

evgkord
Copy link
Contributor

@evgkord evgkord commented Dec 20, 2022 •
edited
Loading

[Cache] RedisTrait::createConnection does not pass auth value from redis sentinel cluster DSN

Q A
Branch? 5.4
Bug fix? yes
New feature? no - bugfix
Deprecations? no
Tickets Fix #48712
License MIT
Doc PR none - bugfix

@carsonbot carsonbot added this to the 5.4 milestone Dec 20, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@evgkord evgkord mentioned this pull request Dec 20, 2022
Closed
@evgkord @nicolas-grekas
Update RedisTrait.php
26ba375 
[Cache] RedisTrait::createConnection does not pass auth value from redis sentinel cluster DSN
@nicolas-grekas
Copy link
Member

Thank you @evgkord.

@nicolas-grekas nicolas-grekas merged commit 4eb8013 into symfony:5.4 Dec 22, 2022
This was referenced Dec 28, 2022
Merged
Merged
Merged
Merged
@ThomasTr ThomasTr mentioned this pull request Dec 28, 2022
Closed
@rikvdh rikvdh mentioned this pull request Dec 29, 2022
Merged
@polina-suzdal polina-suzdal mentioned this pull request Dec 29, 2022
Open
chalasr added a commit that referenced this pull request Dec 29, 2022
@chalasr
bug #48816 [Cache] Fix for RedisAdapter without auth parameter (rikvdh)
51bbdc8 
This PR was merged into the 5.4 branch.

Discussion
----------

[Cache] Fix for RedisAdapter without auth parameter

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #48813
| License       | MIT
| Doc PR        | x

Compatibility with Redis without auth was broken by #48711, this change fixes this.
This applies for all versions (6.x as well).

Commits
-------

0cf91ab fix for caching without auth parameter, broken by #48711, fix for #48813
chalasr added a commit that referenced this pull request Dec 29, 2022
@chalasr
Merge branch '5.4' into 6.0
c95c5b8 
* 5.4:
  fix for caching without auth parameter, broken by #48711, fix for #48813
  Bump Symfony version to 5.4.18
  Update VERSION for 5.4.17
  Update CONTRIBUTORS for 5.4.17
  Update CHANGELOG for 5.4.17
chalasr added a commit that referenced this pull request Dec 29, 2022
@chalasr
Merge branch '6.0' into 6.1
03fb897 
* 6.0:
  fix for caching without auth parameter, broken by #48711, fix for #48813
  Bump Symfony version to 6.0.18
  Update VERSION for 6.0.17
  Update CHANGELOG for 6.0.17
  Bump Symfony version to 5.4.18
  Update VERSION for 5.4.17
  Update CONTRIBUTORS for 5.4.17
  Update CHANGELOG for 5.4.17
chalasr added a commit that referenced this pull request Dec 29, 2022
@chalasr
Merge branch '6.1' into 6.2
de73bee 
* 6.1:
  fix for caching without auth parameter, broken by #48711, fix for #48813
  Bump Symfony version to 6.1.10
  Update VERSION for 6.1.9
  Update CHANGELOG for 6.1.9
  Bump Symfony version to 6.0.18
  Update VERSION for 6.0.17
  Update CHANGELOG for 6.0.17
  Bump Symfony version to 5.4.18
  Update VERSION for 5.4.17
  Update CONTRIBUTORS for 5.4.17
  Update CHANGELOG for 5.4.17
chalasr added a commit that referenced this pull request Dec 29, 2022
@chalasr
Merge branch '6.2' into 6.3
e80c5b3 
* 6.2:
  fix for caching without auth parameter, broken by #48711, fix for #48813
  Bump Symfony version to 6.2.4
  Update VERSION for 6.2.3
  Update CHANGELOG for 6.2.3
  Bump Symfony version to 6.1.10
  Update VERSION for 6.1.9
  Update CHANGELOG for 6.1.9
  Bump Symfony version to 6.0.18
  Update VERSION for 6.0.17
  Update CHANGELOG for 6.0.17
  Bump Symfony version to 5.4.18
  Update VERSION for 5.4.17
  Update CONTRIBUTORS for 5.4.17
  Update CHANGELOG for 5.4.17
  [DependencyInjection] Fix resolving parameters when dumping lazy proxies
@gam6itko gam6itko mentioned this pull request Dec 29, 2022
Closed
@zip-fa
Copy link

zip-fa commented Dec 29, 2022

Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in /var/www/backend/vendor/symfony/cache/Traits/RedisTrait.php on line 229
Redis connection "redis:///var/run/redis/redis.sock" failed: .

After upgrading to this version

@yungpsi
Copy link

yungpsi commented Dec 29, 2022 •
edited
Loading

Our production gone for an hour, but this line in composer fix it:

"symfony/cache”: “<6.1.8"

@chalasr
Copy link
Member

chalasr commented Dec 29, 2022

@zip-fa thanks for the heads up. The deprecation notice should go away with #48823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug Cache Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
6 participants
@evgkord @carsonbot @nicolas-grekas @zip-fa @yungpsi @chalasr