Skip to content

[CssSelector] Add :has() support #49388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: 7.4
Choose a base branch
from
Open

[CssSelector] Add :has() support #49388

wants to merge 18 commits into from

Conversation

franckranaivo
Copy link
Contributor

@franckranaivo franckranaivo commented Feb 15, 2023 •
edited by OskarStark
Loading

Q A
Branch 7.2
Bug fix no
New feature yes
Tickets Fix #40179
Deprecations no
License MIT
Doc PR symfony/symfony-docs#17994

Add support for :has() function.

@carsonbot carsonbot added this to the 6.3 milestone Feb 15, 2023
stof
stof requested changes Feb 15, 2023
View reviewed changes
stof
stof requested changes Feb 20, 2023
View reviewed changes
stof
stof reviewed Feb 20, 2023
View reviewed changes
stof
stof requested changes Feb 21, 2023
View reviewed changes
@franckranaivo franckranaivo force-pushed the css-selector-has-support branch from c1da5e0 to 4e9905c Compare February 26, 2023 15:23
@franckranaivo franckranaivo requested a review from stof February 27, 2023 08:11
stof
stof requested changes Feb 28, 2023
View reviewed changes
@franckranaivo franckranaivo force-pushed the css-selector-has-support branch from 2cc7238 to c0d283d Compare March 2, 2023 10:33
@franckranaivo franckranaivo requested a review from stof March 2, 2023 10:45
franckranaivo added a commit to franckranaivo/symfony-docs that referenced this pull request Mar 2, 2023
@franckranaivo
Add documentation for symfony/symfony#49388
4494613
@franckranaivo franckranaivo mentioned this pull request Mar 2, 2023
Open
@franckranaivo franckranaivo force-pushed the css-selector-has-support branch from b115a18 to 668b75b Compare March 21, 2023 10:38
stof
stof requested changes Mar 21, 2023
View reviewed changes
@franckranaivo franckranaivo marked this pull request as draft March 27, 2023 07:28
@nicolas-grekas nicolas-grekas modified the milestones: 6.3, 6.4 May 23, 2023
@franckranaivo franckranaivo mentioned this pull request Jun 21, 2023
Closed
@franckranaivo franckranaivo force-pushed the css-selector-has-support branch from fe4b0ae to be43dba Compare September 17, 2024 13:47
@javiereguiluz javiereguiluz added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Oct 3, 2024
@fabpot fabpot modified the milestones: 7.2, 7.3 Nov 20, 2024
@fabpot fabpot removed the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Nov 27, 2024
@Bilge
Copy link
Contributor

Bilge commented Feb 3, 2025

Where are we with this? Is this ready to merge?

@OskarStark OskarStark changed the title [CssSelector] Add :has() support [CssSelector] Add :has() support Feb 3, 2025
@franckranaivo franckranaivo force-pushed the css-selector-has-support branch from be43dba to b324b66 Compare February 7, 2025 09:26
franckranaivo and others added 17 commits February 7, 2025 10:28
@franckranaivo
[CssSelector] Add has relation support
18ad9bb
@franckranaivo
[CssSelector] Add test and changelog
fcd700f
@franckranaivo
Add more complex selector inside has node
9358c39
@franckranaivo
Fix syntax standards errors
16550a4
@franckranaivo
Replace node parser for a specific parser
0d5497c
@franckranaivo
Fix parser issue always returning direct descendant
9aa8311
@franckranaivo
Add translator test
06e0d47
@franckranaivo
[CssSelector] Remove unused methods
a9e89ba
@franckranaivo
[CssSelector] Remove unused imports
b30ef12
@franckranaivo
[CssSelector] Fix python original url
a6cd7da
@franckranaivo
[CssSelector] Fix coding standards issue
0b93e0f
@franckranaivo
[CssSelector] Fix BC break by adding @method instead of directly addi…
fbe8e38 
…ng it
@franckranaivo
[CssSelector] Fix coding standard issue
d35086b
@franckranaivo
[CssSelector] Imperative formulation for changelog
bebe4c3
Fix Direct adjacent Relation
c099d95
Add relevant test: shakespeare and htmlIds
31771f1 
Fix incompatible test from bug fix
Fix coding standard issues
0605aca
@franckranaivo franckranaivo force-pushed the css-selector-has-support branch from b324b66 to 22f8228 Compare February 7, 2025 09:28
@franckranaivo franckranaivo force-pushed the css-selector-has-support branch from 22f8228 to 9dc472a Compare February 14, 2025 17:13
@fabpot fabpot modified the milestones: 7.3, 7.4 May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bilge Bilge Bilge left review comments

@stof stof Awaiting requested review from stof

Assignees
No one assigned
Labels
CssSelector Feature Status: Needs Review
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.

CSS selector :has pseudo-class
8 participants
@franckranaivo @Bilge @stof @fabpot @javiereguiluz @nicolas-grekas @xabbuh @carsonbot