Skip to content

[CssSelector] Add :has() support #49388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: 7.4
Choose a base branch
from
Open

[CssSelector] Add :has() support #49388

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
18ad9bb
[CssSelector] Add has relation support
franckranaivo Feb 15, 2023
fcd700f
[CssSelector] Add test and changelog
franckranaivo Feb 15, 2023
9358c39
Add more complex selector inside has node
franckranaivo Feb 20, 2023
16550a4
Fix syntax standards errors
franckranaivo Feb 20, 2023
0d5497c
Replace node parser for a specific parser
franckranaivo Feb 24, 2023
9aa8311
Fix parser issue always returning direct descendant
franckranaivo Feb 25, 2023
06e0d47
Add translator test
franckranaivo Feb 26, 2023
a9e89ba
[CssSelector] Remove unused methods
franckranaivo Feb 26, 2023
b30ef12
[CssSelector] Remove unused imports
franckranaivo Feb 26, 2023
a6cd7da
[CssSelector] Fix python original url
franckranaivo Feb 26, 2023
0b93e0f
[CssSelector] Fix coding standards issue
franckranaivo Feb 27, 2023
fbe8e38
[CssSelector] Fix BC break by adding @method instead of directly addi…
franckranaivo Mar 2, 2023
d35086b
[CssSelector] Fix coding standard issue
franckranaivo Mar 2, 2023
bebe4c3
[CssSelector] Imperative formulation for changelog
franckranaivo Mar 2, 2023
c099d95
Fix Direct adjacent Relation
Jun 21, 2023
31771f1
Add relevant test: shakespeare and htmlIds
Jun 27, 2023
0605aca
Fix coding standard issues
Jun 27, 2023
9dc472a
Fix: remove unused method
Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Direct adjacent Relation
  • Loading branch information
Franck RANAIVO-HARISOA authored and Franck committed Feb 7, 2025
commit c099d95cd3d1dfc3d29b27113bc717df26c146c6
6 changes: 5 additions & 1 deletion src/Symfony/Component/CssSelector/XPath/Extension/RelationExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,12 @@ public function translateRelationChild(XPathExpr $xpath, XPathExpr $combinedXpat

public function translateRelationDirectAdjacent(XPathExpr $xpath, XPathExpr $combinedXpath): XPathExpr
{
$combinedXpath
->addNameTest()
->addCondition('position() = 1');
return $xpath
->addCondition(sprintf('following-sibling::*[(name() = \'%s\') and (position() = 1)]', $combinedXpath->getElement()));
->join('[following-sibling::', $combinedXpath, ']', true)
;
}

public function translateRelationIndirectAdjacent(XPathExpr $xpath, XPathExpr $combinedXpath): XPathExpr
Expand Down