[Scheduler] add schedule name to ScheduledStamp
#49864
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) { | ||
| } | ||
|
|
||
| public function get(): iterable | ||
| { | ||
| foreach ($this->messageGenerator->getMessages() as $message) { | ||
| yield Envelope::wrap($message, [new ScheduledStamp()]); | ||
| yield Envelope::wrap($message, [new ScheduledStamp($this->name)]); |
There was a problem hiding this comment.
but that doesn't work: the name is something that belongs to a schedule, not to the transport. The generated messages can come from many schedules.
There was a problem hiding this comment.
Each schedule has its own transport though.
This was referenced Apr 20, 2023
fabpot
added a commit
that referenced
this pull request
Apr 24, 2023
…ing context (tucksaun) This PR was merged into the 6.3 branch. Discussion ---------- [Scheduler] Make `MessageGenerator` yield some scheduling context | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #50085, "replaces" #50096?, could help with #49864 | License | MIT | Doc PR | no doc yet for Scheduler This PR introduces a new `MessageContext` that `MessageGenerator` should use as key when yielding messages to provide more context about the scheduled message. The consumer of the scheduled messages can decide to use it or not. The PR also adds the wiring to add this context to the `ScheduledStamp` when using Scheduler within Messenger. This allows to add more context but without introducing a hard dependency on Messenger. /cc `@kbond` Note: this PR is not adding the scheduler name (cf #49864) because I don't know exactly where to wire it yet but I don't see anything preventing it to be added to the context once we know where it should belong. Commits ------- 3664d08 [Scheduler] Allow MessageGenerator to provide a MessageContext
|
Closing in favour of #50155. |
fabpot
added a commit
that referenced
this pull request
Apr 26, 2023
This PR was merged into the 6.3 branch. Discussion ---------- [Scheduler] add schedule name to `MessageContext` | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a Alternative to #49864. Commits ------- dc0f0e2 [Scheduler] add schedule name to `MessageContext`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #49838, it would be nice to have the schedule name available on the stamp.