[Serializer] Convert names using denormalize during denormalization #50042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any way to test this? |
ogizanagi
reviewed
Apr 18, 2023
src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
Outdated
Show resolved
Hide resolved
1ebca9a to
044caa7
Compare
|
I've added a test (which is more like an integration test than a unit test, but that seems "normal" in the This proves that I was wrong and the logic is correct. So this is no longer a bug, but we do not support inputs that already have the correct name format as input to normalization. |
|
I'll close for now, as I have no time to investigate how to support this case further. If someone has, you can take my commit as a starting point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is called during denormalization, but it was wrongly calling the normalize function of the name converter. This bug exists since the start of name converters (e14854f). I believe we never caught this bug as the
ObjectNormalizerwould simply set the property using the name converter in the correct direction after initialization.However, with the recent
readonlyfeature this does not work as the constructor sets it to a value and thus the fallback ofObjectNormalizererrors with "Cannot modify readonly property".It might be a bit risky to change this direction in an LTS release, but that is only because people were relying on buggy behavior.