Skip to content

[Cache] Fix success interpretation when pruning cache #50099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2023
Merged

[Cache] Fix success interpretation when pruning cache #50099

merged 1 commit into from
Apr 21, 2023

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Apr 21, 2023 •
edited
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

As discussed in #50095 this PR fixes the interpretation when cache-pruning is considered successfull.

This is changed to use the same semantics used in other places of the codebase, e.g.

symfony/src/Symfony/Component/Cache/Traits/FilesystemCommonTrait.php

Line 62 in 5166629

$ok = ($this->doUnlink($file) || !file_exists($file)) && $ok;

symfony/src/Symfony/Component/Cache/Traits/FilesystemCommonTrait.php

Line 74 in 5166629

$ok = (!is_file($file) || $this->doUnlink($file) || !file_exists($file)) && $ok;

@carsonbot carsonbot added this to the 5.4 milestone Apr 21, 2023
@staabm staabm changed the title [Security] Fix return type of AuthenticationSuccessHandlerInterface::… [Cache] Fix success interpretation when pruning cache Apr 21, 2023
@carsonbot carsonbot changed the title [Cache] Fix success interpretation when pruning cache [Security] Fix success interpretation when pruning cache Apr 21, 2023
@staabm staabm changed the title [Security] Fix success interpretation when pruning cache [Cache] Fix success interpretation when pruning cache Apr 21, 2023
@fabpot
Copy link
Member

fabpot commented Apr 21, 2023

Thank you @staabm.

@fabpot fabpot merged commit d1d7539 into symfony:5.4 Apr 21, 2023
@staabm staabm deleted the fix branch April 21, 2023 14:40
This was referenced Apr 28, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@stof stof stof approved these changes

Assignees
No one assigned
Labels
Bug Security Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@staabm @fabpot @nicolas-grekas @stof @carsonbot