Skip to content

[Form] Relax assertions for ICU 72.1 #51049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2023
Merged

[Form] Relax assertions for ICU 72.1 #51049

merged 1 commit into from
Jul 20, 2023

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 20, 2023

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

In many formatting patterns, ASCII spaces are replaced with Unicode spaces
(e.g., a "thin space").

see https://icu.unicode.org/download/72

@xabbuh
relax assertions for ICU 72.1
658e0bf 
> In many formatting patterns, ASCII spaces are replaced with Unicode spaces
> (e.g., a "thin space").

see https://icu.unicode.org/download/72
@xabbuh xabbuh requested a review from yceruto as a code owner July 20, 2023 14:29
@carsonbot carsonbot added this to the 5.4 milestone Jul 20, 2023
@carsonbot carsonbot changed the title [Form] relax assertions for ICU 72.1 [Form]  relax assertions for ICU 72.1 Jul 20, 2023
@nicolas-grekas nicolas-grekas changed the title [Form]  relax assertions for ICU 72.1 [Form] Relax assertions for ICU 72.1 Jul 20, 2023
@derrabus
Copy link
Member

Thank you Christian.

@derrabus derrabus merged commit 75d6ba0 into symfony:5.4 Jul 20, 2023
@xabbuh xabbuh deleted the icu-72.1-compat branch July 20, 2023 15:14
@xabbuh xabbuh mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

@yceruto yceruto yceruto approved these changes

@HeahDude HeahDude HeahDude approved these changes

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @derrabus @yceruto @HeahDude @carsonbot