Skip to content

[Runtime] Fix property must not be accessed before initialization on SymfonyRuntime #51111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

l-vo
Copy link
Contributor

@l-vo l-vo commented Jul 26, 2023

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR symfony/symfony-docs#...

Introduced by #51068, see #51068 (comment)

@carsonbot carsonbot changed the title Fix property must not be accessed before initialization on SymfonyRuntime [Runtime] Fix property must not be accessed before initialization on SymfonyRuntime Jul 26, 2023
@nicolas-grekas
Copy link
Member

Thank you @l-vo.

@nicolas-grekas nicolas-grekas merged commit ad72245 into symfony:6.4 Jul 26, 2023
@l-vo l-vo deleted the fix_property_must_not_be_accessed_before_initialization_runtime branch July 26, 2023 09:23
@PhilETaylor
Copy link
Contributor

Awesome - thanks @l-vo, this indeed addresses and fixes the #51068 (comment)

@PhilETaylor
Copy link
Contributor

@nicolas-grekas any chance of pushing this to https://github.com/symfony/runtime/tree/6.4 because at the moment 6.4-dev runtime is broken because of this one

Fatal error: Uncaught Error: Typed property Symfony\Component\Runtime\SymfonyRuntime::$input must not be accessed before initialization in /var/www/current/vendor/symfony/runtime/SymfonyRuntime.php:109 Stack trace: #0 /var/www/current/vendor/autoload_runtime.php(16): Symfony\Component\Runtime\SymfonyRuntime->__construct() #1 /var/www/current/public/index.php(13): require_once('...') #2 {main} thrown in /var/www/current/vendor/symfony/runtime/SymfonyRuntime.php on line 109

@nicolas-grekas
Copy link
Member

We have an issue with the splitter, it should be fixed in the very next days if not hours.
Thanks for sponsoring me BTW!

@PhilETaylor
Copy link
Contributor

We have an issue with the splitter, it should be fixed in the very next days if not hours.

ah no worries - sorry to hear that. Absolutely no pressure from me!

Thanks for sponsoring me BTW!

It's only small amounts but Im sure they add up somehow.

@derrabus
Copy link
Member

We're having trouble with our subtree splitter at the moment. Bear with us.

@PhilETaylor
Copy link
Contributor

We're having trouble with our subtree splitter at the moment. Bear with us.

Absolutely! There is no pressure from me at all - thanks for letting me know though. I have manually worked around this bug this week, and will continue to all weekend :) no pressure this end, and now I know the reason it was not split. :)

@fabpot
Copy link
Member

fabpot commented Jul 30, 2023

The splitter has now catch up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants