Skip to content

[FrameworkBundle] add missing default-doctrine-dbal-provider cache pool attribute to XSD #51301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2023
Merged

[FrameworkBundle] add missing default-doctrine-dbal-provider cache pool attribute to XSD #51301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Symfony/Bundle/FrameworkBundle/Resources/config/schema/symfony-1.0.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,7 @@
<xsd:element name="default-psr6-provider" type="xsd:string" minOccurs="0" maxOccurs="1" />
<xsd:element name="default-redis-provider" type="xsd:string" minOccurs="0" maxOccurs="1" />
<xsd:element name="default-memcached-provider" type="xsd:string" minOccurs="0" maxOccurs="1" />
<xsd:element name="default-doctrine-dbal-provider" type="xsd:string" minOccurs="0" maxOccurs="1" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be an attribute, not an element, to match our XML conventions. The other xsd:string elements that cannot occur multiple times should have been attributes too, and we already added them as attributes when documenting the XML config and finding this out. So I suggest that new settings are added only as attribute to avoid continuing the non-conventional format.

And what is the difference between default-doctrine-dbal-provider and default-doctrine-provider ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I favor consistency on this one.

And what is the difference between default-doctrine-dbal-provider and default-doctrine-provider ?

default-doctrine-provider should have been named default-doctrine-cache-provider, it's using an adapter to doctrine/cache

<xsd:element name="default-pdo-provider" type="xsd:string" minOccurs="0" maxOccurs="1" />
<xsd:element name="pool" type="cache_pool" minOccurs="0" maxOccurs="unbounded" />
</xsd:sequence>
Expand Down