[Cache] Allow to use namespace delimiter in cache key #51603
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24881eb to
94ec24f
Compare
94ec24f to
89a1d78
Compare
| { | ||
| if (!\is_string($key)) { | ||
| throw new InvalidArgumentException(sprintf('Cache key must be string, "%s" given.', get_debug_type($key))); | ||
| } | ||
| if ('' === $key) { | ||
| throw new InvalidArgumentException('Cache key length must be greater than zero.'); | ||
| } | ||
| if (false !== strpbrk($key, self::RESERVED_CHARACTERS)) { | ||
| throw new InvalidArgumentException(sprintf('Cache key "%s" contains reserved characters "%s".', $key, self::RESERVED_CHARACTERS)); | ||
| $reservedChars = null === $allowChars ? self::RESERVED_CHARACTERS : str_replace(str_split($allowChars), '', self::RESERVED_CHARACTERS); |
There was a problem hiding this comment.
would it be possible to get rid of the calls to str_replace and str_split? this is on the hotpath and we'd better make this as fast as possible
| @@ -346,7 +346,7 @@ protected function getId(mixed $key): string | |||
| if (\is_string($key) && isset($this->ids[$key])) { | |||
| return $this->namespace.$this->namespaceVersion.$this->ids[$key]; | |||
| } | |||
| \assert('' !== CacheItem::validateKey($key)); | |||
| \assert('' !== CacheItem::validateKey($key, static::NS_SEPARATOR)); | |||
There was a problem hiding this comment.
this one is used for PSR-6 also, isn't it?
|
@vtsykun up to resume this PR? |
|
It would be great to have this feature 👍 I can try to pick up this PR @vtsykun if you are too busy. |
|
@dorrogeray follow up PR welcome then! |
|
@nicolas-grekas I will work on it this week. |
|
Closing in favor of #59813, thanks for giving this a try! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow colon char
:in cache key. It may be useful for redis grouping keys by pattern without creating a many pools for each namespace.Difference between implementation #47561