Skip to content

[Security] Fix for TraceableAuthenticator debug when no Auth #51612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2023
Merged

[Security] Fix for TraceableAuthenticator debug when no Auth #51612

merged 1 commit into from
Sep 10, 2023

Conversation

PhilETaylor
Copy link
Contributor

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #51585 (comment)
License MIT

Fixes regression in PR #51585 and adds unit test

image

@carsonbot carsonbot added this to the 6.4 milestone Sep 10, 2023
@PhilETaylor PhilETaylor changed the title Fix for TraceableAuthenticator debug when no Auth [Security] Fix for TraceableAuthenticator debug when no Auth Sep 10, 2023
@PhilETaylor PhilETaylor mentioned this pull request Sep 10, 2023
Merged
derrabus
derrabus approved these changes Sep 10, 2023
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 … once fabbot is happy.

@PhilETaylor
Copy link
Contributor Author

once fabbot is happy.

Sorry missed that - done now.

@fabpot
Copy link
Member

fabpot commented Sep 10, 2023

Thank you @PhilETaylor.

@fabpot fabpot merged commit cae4ccd into symfony:6.4 Sep 10, 2023
@PhilETaylor
Copy link
Contributor Author

Thanks all - hope you have some time off Sunday evening! :)

@PhilETaylor PhilETaylor deleted the fixtraceableauthdebug branch September 10, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@derrabus derrabus derrabus approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Bug Security Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@PhilETaylor @fabpot @derrabus @carsonbot