-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Update the design of the Symfony Welcome Page #51771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It will be great to add screenshots how it looks like right now. |
@antonkomarev I've updated the PR to include the before screenshots. |
Nice! Could we maybe use more specific icons instead of checkmarks for the 3 main bullet points? Something like:
The list contains 'important' information and I feel it's easily to not read them because it's just another list of bullet points. |
Really nice and clean. I'd suggest separating the 3 factual (& positive-ish) elements from the item requiring user action -- ✅ You are using Symfony XXX version ❓ Your homepage is not configured: create your first page. -- I have a feeling that more people will wonder, 'cool, it works, what do I do now?' than 'why is this page displayed?'... but with no certitude. |
Good point, but I suggest having a warning sign near the debug mode: |
Thank you all for your nice reviews. I'm going to iterate over some of these ideas and will come back with an update. |
Since we usually don't merge features into x.0 releases, what's preventing us from merging this into 6.4? |
I tend to agree with @derrabus here. We communicate regularly than the X.4 releases contains all the new features and Y.0 cleans the deprecated APIs. So this should go in 6.4. |
@derrabus @stof this is the classic "engineering vs product" problem. Engineering team says that new features must go to 6.4 because X.0 branches don't get new features. But for Product team it's important that this new design is only visible in Symfony 7.0 and up, because this is the new design for Symfony 7, not Symfony 6.4 and 7. Personally, I'd make an exception here and merge this into 7.0 only. But I'll do what the team decides 🙏 Thanks! |
the previous PR updating the design was done on v4.4+v5.0 |
7.0 sounds fine to me (it's not "a feature" per se but more like a refresh of the design for a major version). |
What are your thoughts on adding a subtle motion effect to the stars and water? |
Motion effects don't add anything useful here, and might cause trouble on the front of accessibility as movement can cause motion sickness for people with motion sensitivity. https://www.linkedin.com/advice/0/how-do-you-avoid-animation-overload-motion |
Well, then, 50% of webpages have motion on their homepage, and they are all incorrect. https://laravel.com/ I believe adding some effects will generate more excitement for newcomers interested in learning Symfony. For example, when I install Drupal, I encounter an unattractive default page that prompts me to leave quickly. |
The current page is animated, right? So, I suppose the new version will be as well. |
If I'm correct, @javiereguiluz, I didn't notice any effect on the page; I only saw the background color change (which is cool). |
@media (prefers-reduced-motion) {
/* styles to apply if a user's device settings are set to reduced motion */
} I believe animation is not a problem if we leverage this media query https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion |
It's just an idea but something like this, We can do better, of course, if everyone agrees. Recording.2023-10-02.235807.mp4 |
@MGDSoft can you please share the CSS code that you used to add that subtle animation? Thanks! |
ofc! Waves (SVG is the same) function renderWavesSvg()
{
return <<<SVG
<svg aria-hidden="true" focusable="false" style="pointer-events: none" class="wave" width="100%" height="50px" preserveAspectRatio="none" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 1920 75"><defs>
<style>
.a{fill:none}.b{clip-path:url(#a)}.c,.d {fill: var(--light-color); }.d{opacity:0.5;isolation:isolate;}
@keyframes waveMotion {
0% {
transform: scaleX(1) translateX(0);
}
50% {
transform: scaleX(1.5) translateX(-30%);
}
0% {
transform: scaleX(1) translateX(0);
}
}
.b:nth-child(5) {
animation: waveMotion 10s infinite alternate;
}
.b:nth-child(2) {
animation: waveMotion 8s infinite alternate;
}
.b:nth-child(3) {
animation: waveMotion 9s infinite alternate;
}
.b:nth-child(4) {
animation: waveMotion 4s infinite alternate;
}
</style><clipPath id="a"><rect class="a" width="1920" height="75"></rect></clipPath></defs><g class="b"><path class="c" d="M1963,327H-105V65A2647.49,2647.49,0,0,1,431,19c217.7,3.5,239.6,30.8,470,36,297.3,6.7,367.5-36.2,642-28a2511.41,2511.41,0,0,1,420,48"></path></g><g class="b"><path class="d" d="M-127,404H1963V44c-140.1-28-343.3-46.7-566,22-75.5,23.3-118.5,45.9-162,64-48.6,20.2-404.7,128-784,0C355.2,97.7,341.6,78.3,235,50,86.6,10.6-41.8,6.9-127,10"></path></g><g class="b"><path class="d" d="M1979,462-155,446V106C251.8,20.2,576.6,15.9,805,30c167.4,10.3,322.3,32.9,680,56,207,13.4,378,20.3,494,24"></path></g><g class="b"><path class="d" d="M1998,484H-243V100c445.8,26.8,794.2-4.1,1035-39,141-20.4,231.1-40.1,378-45,349.6-11.6,636.7,73.8,828,150"></path></g></svg>
SVG;
} STARS @keyframes stars{
0% {
transform: translateX(0) translateY(0px);
}
33% {
transform: translateX(-20px) translateY(-20px);
}
66% {
transform: translateX(-40px) translateY(-40px);
}
100% {
transform: translateX(0px) translateY(0px);
}
}
header:after {
animation: stars 15s infinite;
} |
Thank you all for your reviews. I've made these changes:
This is how it looks now:
And this is in movement: animation.mp4 |
I love these improvements! ❤️ |
On a wide screen, it looks great, but perhaps on mobile we should add more space between texts as it looks a bit cramped. |
Love it, thx @javiereguiluz for this! |
0e1e7df
to
70f8707
Compare
I've tweaked some margins/paddings/spacing as requested. Thanks. |
f7c4814
to
5d30505
Compare
Thank you @javiereguiluz. |
This PR refreshes the design of the Symfony Welcome Page for Symfony 7.0. This is the page that you see when you create a new Symfony app and browse it without making any change to it.
The new design keeps most of the features of the previous design, including the random color each time you reload the page.
This is how it looks:
This is how it looked before: