Skip to content

[HttpFoundation] Fix type of properties in Request class #51887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

crynobone
Copy link
Contributor

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #51792
License MIT

Additional fixes to #51812

static::$formats can be null to allow lazy-loading:

if (null === static::$formats) {
static::initializeFormats();
}

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@nicolas-grekas
Copy link
Member

Unlike magic methods, isn't this a situation you can deal with on your side?

@crynobone
Copy link
Contributor Author

crynobone commented Oct 8, 2023

CleanShot 2023-10-08 at 09 50 15

The error on Symfony 7 is the same with as before, and also causing Symfony own tests to failed on 7.0 branch:

CleanShot 2023-10-08 at 18 21 09

https://github.com/symfony/symfony/actions/runs/6442148533/job/17492677886

https://github.com/symfony/symfony/actions/runs/6442148533/job/17492678134

@xabbuh
Copy link
Member

xabbuh commented Oct 9, 2023

see also #51904

@fabpot
Copy link
Member

fabpot commented Oct 10, 2023

Thank you @crynobone.

@fabpot fabpot merged commit a0fdeaa into symfony:6.4 Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HttpFoundation] unset Request properties within initialize() will cause issue on any extended Request implementing __isset() and __get()
5 participants