[FrameworkBundle][Routing][Translation][Workflow] Move some compiler passes from FrameworkBundle to components #52032

fancyweb · 2023-10-13T09:05:39Z

Q	A
Branch?	6.4
Bug fix?	no
New feature?	no
Deprecations?	yes
Tickets	-
License	MIT

Move AddExpressionLanguageProvidersPass to symfony/routing
Move DataCollectorTranslatorPass and LoggingTranslatorPass to symfony/translation
Move WorkflowGuardListenerPass to symfony/workflow

src/Symfony/Component/Translation/DependencyInjection/DataCollectorTranslatorPass.php

fancyweb · 2023-10-13T10:13:06Z

src/Symfony/Bundle/FrameworkBundle/FrameworkBundle.php

@@ -157,7 +157,7 @@ public function build(ContainerBuilder $container)
        $this->addCompilerPassIfExists($container, TranslatorPass::class, PassConfig::TYPE_BEFORE_OPTIMIZATION, -32);
        $this->addCompilerPassIfExists($container, TranslatorPathsPass::class, PassConfig::TYPE_AFTER_REMOVING);
        $container->addCompilerPass(new LoggingTranslatorPass());
-        $container->addCompilerPass(new AddExpressionLanguageProvidersPass(false));


There's no constructor so the argument is unused.

src/Symfony/Component/Routing/DependencyInjection/AddExpressionLanguageProvidersPass.php

src/Symfony/Component/Translation/Tests/DependencyInjection/DataCollectorTranslatorPassTest.php

src/Symfony/Component/Workflow/Tests/DependencyInjection/WorkflowGuardListenerPassTest.php

…passes from FrameworkBundle to components

nicolas-grekas · 2023-10-19T15:11:47Z

Thank you @fancyweb.

PhilETaylor · 2023-10-19T17:35:36Z

Think this broke something on a stable 6.4.x-dev upgraded to

- Upgrading symfony/framework-bundle (6.4.x-dev 6499aed => 6.4.x-dev afc557e): Extracting archive

I dont have symfony/workflow installed in my project and now I get this:

 [KO]
Script base:composer:manifest returned with error code 255
!!  Symfony\Component\ErrorHandler\Error\ClassNotFoundError {#175
!!    #message: """
!!      Attempted to load class "WorkflowGuardListenerPass" from namespace "Symfony\Component\Workflow\DependencyInjection".\n
!!      Did you forget a "use" statement for "Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\WorkflowGuardListenerPass"?
!!      """
!!    #code: 0
!!    #file: "./vendor/symfony/framework-bundle/FrameworkBundle.php"
!!    #line: 171
!!    trace: {
!!      ./vendor/symfony/framework-bundle/FrameworkBundle.php:171 { …}
!!      ./vendor/symfony/http-kernel/Kernel.php:630 { …}
!!      ./vendor/symfony/http-kernel/Kernel.php:603 { …}
!!      ./vendor/symfony/http-kernel/Kernel.php:505 { …}
!!      ./vendor/symfony/http-kernel/Kernel.php:757 { …}
!!      ./vendor/symfony/http-kernel/Kernel.php:126 { …}
!!      ./vendor/symfony/framework-bundle/Console/Application.php:184 { …}
!!      ./vendor/symfony/framework-bundle/Console/Application.php:72 { …}
!!      ./vendor/symfony/console/Application.php:175 { …}
!!      ./vendor/symfony/runtime/Runner/Symfony/ConsoleApplicationRunner.php:49 { …}
!!      ./vendor/autoload_runtime.php:29 { …}
!!      ./bin/console:11 {
!!        ›
!!        › require_once dirname(__DIR__).'/vendor/autoload_runtime.php';
!!        ›
!!        arguments: {
!!          "/Users/phil/Sites/myBackups.guru/vendor/autoload_runtime.php"
!!        }
!!      }
!!    }
!!  }
!!  2023-10-19T17:32:19+00:00 [critical] Uncaught Error: Class "Symfony\Component\Workflow\DependencyInjection\WorkflowGuardListenerPass" not found
!!  2023-10-19T17:32:19+00:00 [info] User Deprecated: Since symfony/framework-bundle 6.4: The "Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\WorkflowGuardListenerPass" class is deprecated, use "Symfony\Component\Workflow\DependencyInjection\WorkflowGuardListenerPass" instead.
!!
Script @auto-scripts was called via post-update-cmd

fancyweb · 2023-10-19T17:46:07Z

I missed that. Translation and Workflow are not hard dependencies of FWB so we can’t require the new compiler passes unconditionally.

…

On Thu 19 Oct 2023 at 19:35, Phil E. Taylor ***@***.***> wrote: Think this broke something on a stable 6.4.x-dev upgraded to - Upgrading symfony/framework-bundle (6.4.x-dev 6499aed => 6.4.x-dev afc557e): Extracting archive I dont have symfony/workflow installed in my project and now I get this: [KO] Script base:composer:manifest returned with error code 255 !! Symfony\Component\ErrorHandler\Error\ClassNotFoundError {#175 !! #message: """ !! Attempted to load class "WorkflowGuardListenerPass" from namespace "Symfony\Component\Workflow\DependencyInjection".\n !! Did you forget a "use" statement for "Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\WorkflowGuardListenerPass"? !! """ !! #code: 0 !! #file: "./vendor/symfony/framework-bundle/FrameworkBundle.php" !! #line: 171 !! trace: { !! ./vendor/symfony/framework-bundle/FrameworkBundle.php:171 { …} !! ./vendor/symfony/http-kernel/Kernel.php:630 { …} !! ./vendor/symfony/http-kernel/Kernel.php:603 { …} !! ./vendor/symfony/http-kernel/Kernel.php:505 { …} !! ./vendor/symfony/http-kernel/Kernel.php:757 { …} !! ./vendor/symfony/http-kernel/Kernel.php:126 { …} !! ./vendor/symfony/framework-bundle/Console/Application.php:184 { …} !! ./vendor/symfony/framework-bundle/Console/Application.php:72 { …} !! ./vendor/symfony/console/Application.php:175 { …} !! ./vendor/symfony/runtime/Runner/Symfony/ConsoleApplicationRunner.php:49 { …} !! ./vendor/autoload_runtime.php:29 { …} !! ./bin/console:11 { !! › !! › require_once dirname(__DIR__).'/vendor/autoload_runtime.php'; !! › !! arguments: { !! "/Users/phil/Sites/myBackups.guru/vendor/autoload_runtime.php" !! } !! } !! } !! } !! 2023-10-19T17:32:19+00:00 [critical] Uncaught Error: Class "Symfony\Component\Workflow\DependencyInjection\WorkflowGuardListenerPass" not found !! 2023-10-19T17:32:19+00:00 [info] User Deprecated: Since symfony/framework-bundle 6.4: The "Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\WorkflowGuardListenerPass" class is deprecated, use "Symfony\Component\Workflow\DependencyInjection\WorkflowGuardListenerPass" instead. !! Script @auto-scripts was called via post-update-cmd — Reply to this email directly, view it on GitHub <#52032 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA35DB3Q7YP3FY7HZUNTX3TYAFQHHAVCNFSM6AAAAAA562T5I2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZRGQZTCOJXGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

PhilETaylor · 2023-10-19T22:26:38Z

@fancyweb I have logged this here #52187 so that this comment doesnt get lost, I see you posted by email and might be unable to address it right away, so hope an open issue prevents duplicate issues (No pressure from me or rush needed, but the framework in 6.4.x is broken at the moment :)) - Also PayPal 💰

… only if it exists (smnandre) This PR was merged into the 6.4 branch. Discussion ---------- [FrameworkBundle][Workflow] Add `WorflowGuardListenerPass` only if it exists | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #52187 | License | MIT As spotted by `@PhilETaylor` (in [this comment](#52032 (comment))) the framework is broken in 6.4-dev when the worflow component is not installed. This PR fixes that by registering the compiler pass only if available. Commits ------- 1ba348a Add WorflowGuardListenerPass only if it exists

… only if it exists (smnandre) This PR was merged into the 6.4 branch. Discussion ---------- [FrameworkBundle][Workflow] Add `WorflowGuardListenerPass` only if it exists | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #52187 | License | MIT As spotted by `@PhilETaylor` (in [this comment](symfony/symfony#52032 (comment))) the framework is broken in 6.4-dev when the worflow component is not installed. This PR fixes that by registering the compiler pass only if available. Commits ------- 1ba348a7e13 Add WorflowGuardListenerPass only if it exists

…cyweb) This PR was merged into the 7.0 branch. Discussion ---------- [FrameworkBundle] Remove deprecated compiler passes | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT Remove deprecated code in #52032 Commits ------- 7984404 [FrameworkBundle] Remove deprecated compiler passes

…er passes (fancyweb) This PR was merged into the 6.4 branch. Discussion ---------- [FrameworkBundle] Fix requiring moved translation compiler passes | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #52032 (comment) | License | MIT Those 2 also need to be required conditionally since symfony/translation is not a hard dependency of FWB. Commits ------- 2b95681 [FrameworkBundle] Fix requiring moved translation compiler passes

…er passes (fancyweb) This PR was merged into the 6.4 branch. Discussion ---------- [FrameworkBundle] Fix requiring moved translation compiler passes | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | symfony/symfony#52032 (comment) | License | MIT Those 2 also need to be required conditionally since symfony/translation is not a hard dependency of FWB. Commits ------- 2b95681764 [FrameworkBundle] Fix requiring moved translation compiler passes

fancyweb requested review from lyrixx and welcoMattic as code owners October 13, 2023 09:05

carsonbot added Status: Needs Review Deprecation FrameworkBundle Routing Translation Workflow labels Oct 13, 2023

carsonbot added this to the 6.4 milestone Oct 13, 2023

welcoMattic reviewed Oct 13, 2023

View reviewed changes

src/Symfony/Component/Translation/DependencyInjection/DataCollectorTranslatorPass.php Outdated Show resolved Hide resolved

fancyweb force-pushed the fwb/move-workflow-cp branch from 058c80e to d6e5b16 Compare October 13, 2023 10:08

fancyweb commented Oct 13, 2023

View reviewed changes

OskarStark reviewed Oct 13, 2023

View reviewed changes

src/Symfony/Component/Routing/DependencyInjection/AddExpressionLanguageProvidersPass.php Outdated Show resolved Hide resolved

fancyweb force-pushed the fwb/move-workflow-cp branch 2 times, most recently from 5041b7d to ed7a6ff Compare October 18, 2023 07:25

nicolas-grekas added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Oct 18, 2023

nicolas-grekas approved these changes Oct 18, 2023

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Oct 18, 2023

fancyweb force-pushed the fwb/move-workflow-cp branch from ed7a6ff to 722d04e Compare October 18, 2023 07:40

stof reviewed Oct 18, 2023

View reviewed changes

src/Symfony/Component/Translation/Tests/DependencyInjection/DataCollectorTranslatorPassTest.php Outdated Show resolved Hide resolved

src/Symfony/Component/Workflow/Tests/DependencyInjection/WorkflowGuardListenerPassTest.php Outdated Show resolved Hide resolved

[FrameworkBundle][Routing][Translation][Workflow] Move some compiler …

9bde6ce

…passes from FrameworkBundle to components

fancyweb force-pushed the fwb/move-workflow-cp branch from 722d04e to 9bde6ce Compare October 18, 2023 16:23

nicolas-grekas merged commit f5178e0 into symfony:6.4 Oct 19, 2023

fancyweb deleted the fwb/move-workflow-cp branch October 19, 2023 15:16

fancyweb mentioned this pull request Oct 19, 2023

[FrameworkBundle] Remove deprecated compiler passes #52182

Merged

PhilETaylor mentioned this pull request Oct 19, 2023

Regression: Attempted to load class "WorkflowGuardListenerPass" from namespace #52187

Closed

smnandre mentioned this pull request Oct 20, 2023

[FrameworkBundle][Workflow] Add WorflowGuardListenerPass only if it exists #52188

Merged

fancyweb mentioned this pull request Oct 20, 2023

[FrameworkBundle] Fix requiring moved translation compiler passes #52190

Merged

This was referenced Oct 21, 2023

Release v6.4.0-BETA1 #52220

Merged

Release v7.0.0-BETA1 #52224

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[FrameworkBundle][Routing][Translation][Workflow] Move some compiler passes from FrameworkBundle to components #52032

[FrameworkBundle][Routing][Translation][Workflow] Move some compiler passes from FrameworkBundle to components #52032

Uh oh!

fancyweb commented Oct 13, 2023

Uh oh!

Uh oh!

fancyweb Oct 13, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nicolas-grekas commented Oct 19, 2023

Uh oh!

PhilETaylor commented Oct 19, 2023

Uh oh!

fancyweb commented Oct 19, 2023 via email

Uh oh!

PhilETaylor commented Oct 19, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

[FrameworkBundle][Routing][Translation][Workflow] Move some compiler passes from FrameworkBundle to components #52032

[FrameworkBundle][Routing][Translation][Workflow] Move some compiler passes from FrameworkBundle to components #52032

Uh oh!

Conversation

fancyweb commented Oct 13, 2023

Uh oh!

Uh oh!

fancyweb Oct 13, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nicolas-grekas commented Oct 19, 2023

Uh oh!

PhilETaylor commented Oct 19, 2023

Uh oh!

fancyweb commented Oct 19, 2023 via email

Uh oh!

PhilETaylor commented Oct 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

PhilETaylor commented Oct 19, 2023 •

edited

Loading