Skip to content

[Form] skip tests that do not work with ICU 71.1 #52245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2023
Merged

[Form] skip tests that do not work with ICU 71.1 #52245

merged 1 commit into from
Nov 30, 2023

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Oct 23, 2023

Q A
Branch? 7.0
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

@xabbuh xabbuh requested a review from yceruto as a code owner October 23, 2023 08:02
@xabbuh xabbuh force-pushed the appveyor-form branch 10 times, most recently from f9d142e to 507f2f7 Compare October 23, 2023 14:46
@maxbeckers
Copy link
Contributor

@xabbuh does this help you #52206 (comment) ?

@xabbuh
Copy link
Member Author

xabbuh commented Oct 24, 2023

@maxbeckers Kind of, I suspect the ICU version used to be the cause here. At least that the only relevant difference that I can spot compared to 6.4 (see #52251).

Which version do you have locally? And can you also try different versions?

@maxbeckers
Copy link
Contributor

maxbeckers commented Oct 24, 2023 •
edited
Loading

@xabbuh you're right.

When i run it with 70.1, it works. When I use 71.1, it fails.

@xabbuh
Copy link
Member Author

xabbuh commented Oct 24, 2023

73.2 works for me too.

@maxbeckers
Copy link
Contributor

I currently only have the two versions I tried for testing.

maxbeckers
maxbeckers reviewed Oct 24, 2023
View reviewed changes
src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTypeTest.php Outdated
var_dump($error->getCause()->getInvalidMessage());
var_dump($error->getCause()->getInvalidMessageParameters());
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output of this looks like that if it helps:

string(4) "71.1"
string(26) "Please enter a valid date."
string(84) "Unable to reverse value for property path "date": Date parsing failed: U_PARSE_ERROR"
NULL
array(0) {
}

@carsonbot carsonbot changed the title [Form] debug failures on AppVeyor [Form]  debug failures on AppVeyor Oct 31, 2023
@xabbuh xabbuh mentioned this pull request Nov 30, 2023
Closed
@xabbuh xabbuh changed the base branch from 7.0 to 5.4 November 30, 2023 10:41
@xabbuh xabbuh changed the title [Form]  debug failures on AppVeyor [Form] skip tests that do not work with ICU 71.1 Nov 30, 2023
@xabbuh xabbuh merged commit 0719891 into symfony:5.4 Nov 30, 2023
@xabbuh xabbuh deleted the appveyor-form branch November 30, 2023 11:32
@yceruto yceruto mentioned this pull request Dec 9, 2023
Closed
@nicolas-grekas nicolas-grekas added this to the 5.4 milestone Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxbeckers maxbeckers maxbeckers left review comments

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Form Status: Needs Work
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @maxbeckers @nicolas-grekas