[Cache] remove Doctrine DBAL < 3.3 related code #52685
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "7.0". Cheers! Carsonbot |
derrabus
reviewed
Nov 22, 2023
| @@ -375,8 +375,7 @@ private function getServerVersion(): string | |||
| return $this->serverVersion; | |||
| } | |||
|
|
|||
| // The condition should be removed once support for DBAL <3.3 is dropped | |||
| $conn = method_exists($this->conn, 'getNativeConnection') ? $this->conn->getNativeConnection() : $this->conn->getWrappedConnection(); | |||
| $conn = $this->conn->getNativeConnection(); | |||
| if ($conn instanceof ServerInfoAwareConnection) { | |||
There was a problem hiding this comment.
Hmm, this does not really make sense. If we call getNativeConnection(), we get the native handle of the PHP extension used, e.g. a mysqli instance or an sqlsrv resource. Those objects/resources won't ever implement ServerInfoAwareConnection. Something's off here.
There was a problem hiding this comment.
I guess you are right. Looks like we first need to fix it in a way similar to #52715.
nicolas-grekas
added a commit
that referenced
this pull request
Nov 24, 2023
This PR was merged into the 5.4 branch. Discussion ---------- [Cache] fix detecting the database server version | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | #52685 (comment) | License | MIT Commits ------- 33a65ca fix detecting the database server version
symfony-splitter
pushed a commit
to symfony/cache
that referenced
this pull request
Nov 24, 2023
This PR was merged into the 5.4 branch. Discussion ---------- [Cache] fix detecting the database server version | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | symfony/symfony#52685 (comment) | License | MIT Commits ------- 33a65ca9cd5 fix detecting the database server version
|
My alternative proposal: #52720. |
|
closing in favour of #52720 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following the merge up of #52459