[Routing] Revert " Fix removing aliases pointing to removed route in RouteCollection::remove()" #52831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…outeCollection::remove()" This reverts commit 238894b.
xabbuh
approved these changes
Nov 30, 2023
HypeMC
reviewed
Nov 30, 2023
| unset($this->aliases[$k]); | ||
| } | ||
| foreach ((array) $name as $n) { | ||
| unset($this->routes[$n], $this->priorities[$n], $this->aliases[$n]); |
There was a problem hiding this comment.
Maybe I'm missing something here, but why not have this method remove both an alias, if it's an alias, or a route with all its aliases, if it's a route?
There was a problem hiding this comment.
I also wondered the same. That'd make sense to me.
|
Another thing about this solution: So when someone uses FQCN for their routing and they add Hosts or Prefixes, that will not work anymore. |
|
Closing in favor of #52845 |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 1, 2023
…ve() (fancyweb) This PR was merged into the 5.4 branch. Discussion ---------- [Routing] Restore aliases removal in RouteCollection::remove() | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | #52806 (comment) | License | MIT As suggested in #52831 (comment) It's still a small behavior change on 5.4, let's see what people think 😃 Commits ------- 3c6dc17 [Routing] Restore aliases removal in RouteCollection::remove()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to find another solution that doesn't change the behavior on 5.4 😕