Skip to content

[Mailer] Be able to create a stream without TLS #52944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

aslangery
Copy link

@aslangery aslangery commented Dec 8, 2023

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues --
License MIT

It was not possible to create a stream without TLS

fix: It's not possible to create a stream without tls
Update EsmtpTransportFactory.php
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@aslangery aslangery changed the base branch from 7.1 to 5.4 December 8, 2023 13:19
@aslangery aslangery changed the base branch from 5.4 to 7.1 December 8, 2023 13:20
@OskarStark OskarStark modified the milestones: 7.1, 5.4 Dec 8, 2023
@carsonbot carsonbot changed the title FIX: It was not possible to create a stream without tls [Mailer] FIX: It was not possible to create a stream without tls Dec 8, 2023
@OskarStark OskarStark changed the title [Mailer] FIX: It was not possible to create a stream without tls [Mailer] Be able to create a stream without TLS Dec 8, 2023
@symfony symfony deleted a comment from carsonbot Dec 8, 2023
@OskarStark
Copy link
Contributor

Can you please add a test case? Thanks

@OskarStark
Copy link
Contributor

Why not using àWhy don't you using smtps` as scheme instead? Can you explain?

@aslangery
Copy link
Author

Why not using àWhy don't you using smtps` as scheme instead? Can you explain?

Our client has an incorrectly configured mail server. On swiftmailer this did not cause problems, but when switching to symfonymailer the connection stopped working

@OskarStark
Copy link
Contributor

I am not sure we want to work around wrong configured mail servers 🤔

cc @fabpot

@aslangery
Copy link
Author

I am not sure we want to work around wrong configured mail servers 🤔

cc @fabpot

This isn't really a mistake. On servers you can configure an arbitrary port for smtp. Even 465, although it is the default for smtps

@nicolas-grekas nicolas-grekas modified the milestones: 5.4, 7.1 Jan 29, 2024
@nicolas-grekas
Copy link
Member

This might break existing client that forgot to add the final "s" to their scheme so I'm not sure I would do it this way.
Instead, we could add a tls option - maybe by tweaking #53621
Closing for this reason, let's continue on the linked PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants