-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Mailer] Be able to create a stream without TLS #52944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix: It's not possible to create a stream without tls
Update EsmtpTransportFactory.php
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
Can you please add a test case? Thanks |
Why not using |
Our client has an incorrectly configured mail server. On swiftmailer this did not cause problems, but when switching to symfonymailer the connection stopped working |
I am not sure we want to work around wrong configured mail servers 🤔 cc @fabpot |
This isn't really a mistake. On servers you can configure an arbitrary port for smtp. Even 465, although it is the default for smtps |
This might break existing client that forgot to add the final "s" to their scheme so I'm not sure I would do it this way. |
It was not possible to create a stream without TLS