-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Cache][DependencyInjection][Lock][Mailer][Messenger][Notifier][Translation] Url decode username and passwords from parse_url()
results
#53320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for having a look.
Let's go with a bugfix on this one to me.
And again a DSN component would help us across the whole codebase I know this was discussed quite often in the past. Anything changed your mind @nicolas-grekas ? cc @Nyholm |
All this makes me think we need a working url parser... (a dsn component is another story.) |
To be reusable in a dedicated component ofc, but as this is util and no "domain", I don't know either 🤷♂️ but it sounds good 👍 |
Maybe this UrlParser could belong to HttpFoundation? If this is something that could happen, I'll gladly implement this and leverage it in the numerous DSN parsing processes the codebase counts. |
0a90d41
to
1c0fbf2
Compare
Rebased to 5.4 to make it a bug fix. I'll have a look at what can be done with some UrlParser/DsnParser to have a global logic over every DSN parsing |
1c0fbf2
to
1f2b2c1
Compare
…lation] Url decode username and passwords from `parse_url()` results
1f2b2c1
to
f0292f2
Compare
Thank you @alexandre-daubois. |
Following #52758 (review)
I guess this doesn't an entry in the changelog, does it? I replaced
urldecode
byrawurldecode
and$parsedDsn
by$params
, as latest updates to the code used the latter.