I'm not sure if this is the way to do it to be honest.

If I understand it correctly, when http_client is disabled, those services no longer register. That means that those functionality will not work anymore.

While with my PR, I did not inject the default http_client but instead, let the service class in question create it's own HttpClient.

I think this PR will actually break things for people that have http_client disabled.

Another solution is to do the following:

If the http_client service exists, use and inject that. Otherwise, create a new HttpClient service and inject it inline.

The AssetMapper component already requires HttpClient. But on the Framework level, there is no guarantee that the http_client is registered (because it was disabled).

I think this PR will actually break things for people that have http_client disabled.

Not sure about that, those service have already been unusable before as you pointed out in your PR. So this doesn't change here.

That's right, it was already broken indeed.

Solving it like this would be the way to go if you ask me: #57219 (comment)

Instead of removing the functionality that produced an error, it would solve the functionality, without needing addition work for the user.

If the http_client service exists, use and inject that. Otherwise, create a new HttpClient service and inject it inline.

@xabbuh what do you about this ?

I can create a PR in this direction if you want

(as asset-mapper does require http-client as direct dependency, it would allow to fix things for everyone.... or am i beeing naive here ?)