Skip to content

[AssetMapper] Fix AssetMapper commands need http_client service #57336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Jun 6, 2024

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #57073
License MIT

Alternative solution to #57219

@carsonbot carsonbot added this to the 6.4 milestone Jun 6, 2024
@carsonbot carsonbot changed the title Fix AssetMapper commands need http_client service [AssetMapper] Fix AssetMapper commands need http_client service Jun 7, 2024
) {
$this->httpClient = $httpClient ?? HttpClient::create();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already suggested in #57073 which I considered to be a new feature (see #57073 (comment)).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sorry i've lost my way after #57219 :(

(Maybe stupid idea) Could we, for Symfony 6.4 & 7.1, register a "fake" command (when http_client is not enabeld) that would display a message asking to enable http_client ?

Or would this be not worth it ?

As 6.4 is an LTS, i'm afraid of the number of people who could be impacted...
... but after all there is probably not that many people disabling http_client in framework bundle ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Maybe stupid idea) Could we, for Symfony 6.4 & 7.1, register a "fake" command (when http_client is not enabeld) that would display a message asking to enable http_client ?

That's exactly what I was thinking for the Symfony UX Icon search command :)

@smnandre smnandre closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants