[AssetMapper] Skip test with chmod failing on Windows
#57375
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Jun 27, 2024
| @@ -43,6 +43,10 @@ public function testGetStorageDir() | |||
|
|
|||
| public function testSaveThrowsWhenVendorDirectoryIsNotWritable() | |||
| { | |||
| if ('\\' === \DIRECTORY_SEPARATOR) { | |||
| $this->markTestSkipped('chmod is not supported on Windows'); | |||
There was a problem hiding this comment.
Is this still necessary with the change done in the Filesystem component?
There was a problem hiding this comment.
I think i missed these changes... :/
KInda still think this is the main reason... but of course if ij the meantime something has been fixed on FS ... 😶🌫️
|
Let's try #57574 |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 28, 2024
…grekas) This PR was merged into the 5.4 branch. Discussion ---------- [Filesystem] Fix Filesystem::remove() on Windows | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | #57375, #57346 | License | MIT Let's experiment with `@smnandre`'s theory. Commits ------- 2b50dea [Filesystem] Fix Filesystem::remove() on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test to check solution for ##57346
(cannot test on Windows elsewhere)