[Filesystem] Fix Filesystem::remove() on Windows #57574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 28, 2024
This was referenced Jun 28, 2024
Merged
Merged
Merged
Merged
github-merge-queue bot
pushed a commit
to Lendable/composer-license-checker
that referenced
this pull request
Jun 28, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [symfony/filesystem](https://symfony.com) ([source](https://togithub.com/symfony/filesystem)) | `6.4.8` -> `6.4.9` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>symfony/filesystem (symfony/filesystem)</summary> ### [`v6.4.9`](https://togithub.com/symfony/filesystem/releases/tag/v6.4.9) [Compare Source](https://togithub.com/symfony/filesystem/compare/v6.4.8...v6.4.9) **Changelog** (symfony/filesystem@v6.4.8...v6.4.9) - bug [symfony/symfony#57574](https://togithub.com/symfony/symfony/issues/57574) \[Filesystem] Fix Filesystem::remove() on Windows ([@​nicolas-grekas](https://togithub.com/nicolas-grekas)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Lendable/composer-license-checker). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
appveyor still failing after this PR, your guess didn't work this time @smnandre :) |
|
Well could we use the old « dot » thing on Windows ? On my PR it seems to work well (and i’m not sure if the alpha order is the cause or the dot dot thing .. but i’m sure this change is the root of the problem — or at least what exposes it) |
|
I really really doubt that changing for a dot would fix anything. We should look for something else. |
|
|
|
Maybe something there: rectorphp/rector-src#5514
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's experiment with @smnandre's theory.