Skip to content

[PropertyInfo] convert legacy types to TypeInfo types if getType() is not implemented #57459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2025
Merged

[PropertyInfo] convert legacy types to TypeInfo types if getType() is not implemented #57459

merged 1 commit into from
Jan 18, 2025

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 19, 2024

Q A
Branch? 7.1
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #57360
License MIT

@xabbuh xabbuh requested a review from dunglas as a code owner June 19, 2024 20:54
@carsonbot carsonbot added this to the 7.1 milestone Jun 19, 2024
@xabbuh xabbuh mentioned this pull request Jun 19, 2024
Closed
@xabbuh
Copy link
Member Author

xabbuh commented Jun 19, 2024

@hantsy FYI, if you would like to try this with your application

@xabbuh xabbuh mentioned this pull request Jun 19, 2024
Closed
@stof
Copy link
Member

stof commented Jun 19, 2024

btw, the testsuite should probably have a legacy test covering the usage of a legacy extractor (not implementing the new method) inside those.

stof
stof requested changes Jun 19, 2024
View reviewed changes
Copy link
Member

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests covering this BC layer

@xabbuh xabbuh force-pushed the issue-57360 branch 2 times, most recently from e2a595a to c8c4b55 Compare June 20, 2024 06:12
@xabbuh
Copy link
Member Author

xabbuh commented Jun 20, 2024

I have added some tests for this fix

@xabbuh xabbuh force-pushed the issue-57360 branch 2 times, most recently from 76bcfb5 to 92a89bc Compare June 22, 2024 05:05
@xabbuh xabbuh force-pushed the issue-57360 branch 2 times, most recently from 309d2c1 to 835af97 Compare July 1, 2024 09:57
@xabbuh
Copy link
Member Author

xabbuh commented Jul 4, 2024

Status: Needs Review

@xabbuh xabbuh requested a review from stof July 17, 2024 07:03
@ToshY
Copy link
Contributor

ToshY commented Jul 28, 2024

@stof Could you spare some time to re-review this?

@xabbuh xabbuh merged commit bfe7569 into symfony:7.1 Jan 18, 2025
10 of 11 checks passed
@xabbuh xabbuh deleted the issue-57360 branch January 18, 2025 09:07
This was referenced Jan 29, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansys phansys phansys approved these changes

@mtarld mtarld mtarld approved these changes

@chalasr chalasr chalasr approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@stof stof Awaiting requested review from stof

Assignees
No one assigned
Labels
Bug PropertyInfo Status: Reviewed
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
7 participants
@xabbuh @stof @ToshY @phansys @mtarld @chalasr @carsonbot