[HttpKernel] Enable optional cache-warmers when cache-dir != build-dir #57553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0b0a8fa to
8eadd68
Compare
|
Your second approach seems better to achieve what was missing 👍 |
stof
reviewed
Jun 27, 2024
| $cacheWarmer->enableOptionalWarmers(); | ||
| } | ||
|
|
||
| $preload = array_merge($preload, (array) $cacheWarmer->warmUp($buildDir, $buildDir)); |
There was a problem hiding this comment.
because passing the cacheDir is highly confusing (which one should I use?), and warmers don't need to know where the cache-dir is when there is a build-dir (but they need to know they're running for the buildDir, so the argument needs to be passed, thus 2)
There was a problem hiding this comment.
I've reverted this part: passing the cacheDir actually forces warmers to opt-in for the build dir if they really want to support it
this is safer: not updated cache warmer will continue writing to the cache dir
nicolas-grekas
added a commit
that referenced
this pull request
Jun 28, 2024
This PR was merged into the 7.1 branch. Discussion ---------- [FrameworkBundle] Fix warming up routes | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Follows #52962 and builds on the semantics of #57553. Commits ------- cc918e9 [FrameworkBundle] Fix warming up routes
8eadd68 to
7aa625b
Compare
This was referenced Jun 28, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be running optional cache warmers during kernel compilation when cache-dir != build-dir. This gives them an opportunity to run, which is missing right now.