Skip to content

[Console] Add finished indicator to ProgressIndicator #57576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2024
Merged

[Console] Add finished indicator to ProgressIndicator #57576

merged 1 commit into from
Oct 6, 2024

Conversation

LauLaman
Copy link
Contributor

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
Issues
License MIT

Add a (configurable) finished indicator to the progress indicator to show that the progress is finished instead of last used indicator value.
This will make the output a bit nicer

instead of

 - Process A (4 secs, 8.0 MiB)
 \ Process B (1 min, 39 secs, 18.0 MiB)
 - Process C (7 secs, 18.0 MiB)
 - Process D (48 secs, 20.0 MiB)
 / Process E (45 secs, 20.0 MiB)

The output will look now like this:

 ✔ Process A (4 secs, 8.0 MiB)
 ✔ Process B (1 min, 39 secs, 18.0 MiB)
 ✔ Process C (7 secs, 18.0 MiB)
 ✔ Process D (48 secs, 20.0 MiB)
 ✔ Process E (45 secs, 20.0 MiB)

@LauLaman LauLaman requested a review from chalasr as a code owner June 28, 2024 09:54
@carsonbot carsonbot added this to the 7.2 milestone Jun 28, 2024
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@LauLaman LauLaman force-pushed the cli-progress-indicator branch 5 times, most recently from 88fb194 to 80f36c5 Compare July 3, 2024 11:41
GromNaN
GromNaN reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@OskarStark OskarStark changed the title [Console] Add finished indicator to ProgressIndicator [Console] Add finished indicator to ProgressIndicator Jul 5, 2024
@fabpot
Copy link
Member

fabpot commented Sep 6, 2024

@LauLaman Do you have time to have a look at the feedback?

@LauLaman
Copy link
Contributor Author

LauLaman commented Sep 9, 2024

@fabpot Yes will look at this the coming week/weekend

@LauLaman LauLaman force-pushed the cli-progress-indicator branch 4 times, most recently from c988772 to d7ac9aa Compare October 1, 2024 13:03
@LauLaman
Copy link
Contributor Author

LauLaman commented Oct 1, 2024

@fabpot Sorry it took a bit longer.. shoud be good now

GromNaN
GromNaN requested changes Oct 1, 2024
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready.

alexandre-daubois
alexandre-daubois reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@alexandre-daubois alexandre-daubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once @GromNaN comments are addressed!

@LauLaman LauLaman force-pushed the cli-progress-indicator branch from d7ac9aa to d296791 Compare October 2, 2024 10:15
@LauLaman LauLaman force-pushed the cli-progress-indicator branch from d296791 to b13fffc Compare October 2, 2024 11:28
@LauLaman
Copy link
Contributor Author

LauLaman commented Oct 2, 2024

@GromNaN Thanks! Done!

@fabpot
Copy link
Member

fabpot commented Oct 6, 2024

Thank you @LauLaman.

@fabpot fabpot merged commit 307ad5f into symfony:7.2 Oct 6, 2024
9 of 10 checks passed
@fabpot fabpot mentioned this pull request Oct 6, 2024
Closed
@LauLaman LauLaman deleted the cli-progress-indicator branch October 9, 2024 13:20
@fabpot fabpot mentioned this pull request Oct 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@GromNaN GromNaN GromNaN approved these changes

@alexandre-daubois alexandre-daubois alexandre-daubois approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Console Feature Status: Reviewed
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
5 participants
@LauLaman @carsonbot @fabpot @GromNaN @alexandre-daubois