Skip to content

[HttpKernel] Compare paths after realpath() has been applied to both #57593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 29, 2024

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

@xabbuh
Copy link
Member Author

xabbuh commented Jun 29, 2024

This does not look like the right solution. The tests used to work before #57553 without the files being present.

@xabbuh xabbuh closed this Jun 29, 2024
@xabbuh xabbuh deleted the security-bundle-functional-tests branch June 29, 2024 04:14
@xabbuh xabbuh restored the security-bundle-functional-tests branch June 29, 2024 04:19
@xabbuh xabbuh reopened this Jun 29, 2024
@xabbuh xabbuh force-pushed the security-bundle-functional-tests branch from e6479ea to ebff9ed Compare June 29, 2024 04:23
@xabbuh xabbuh changed the title [SecurityBundle] add missing routing configs [FrameworkBundle][SecurityBundle] add missing routing configs in functional tests Jun 29, 2024
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jun 29, 2024

The issue is only on appveyor right?
Then here is why: before #57553, the router cache warmer wasn't triggered, and since routes where never used by these test cases, we didn't need these yaml files. It looks like on Windows, we take the $cacheDir !== $buildDir codepath and we enable the optional cache warmers.
I think we should figure out why these paths are different on Windows and fix that part.
The fact that these yaml files are missing is actually a good thing: it proves that we didn't run any logic to care about routes while routes are unused, which is good for the perf of tests.

@xabbuh
Copy link
Member Author

xabbuh commented Jun 29, 2024

The issue is only on appveyor right?

I can observe the same behaviour locally. I will investigate a bit more.

@xabbuh xabbuh force-pushed the security-bundle-functional-tests branch from ebff9ed to d58facc Compare June 29, 2024 06:54
@xabbuh xabbuh changed the title [FrameworkBundle][SecurityBundle] add missing routing configs in functional tests [FrameworkBundle][SecurityBundle] Compare paths after realpath() has been applied to both Jun 29, 2024
@xabbuh xabbuh force-pushed the security-bundle-functional-tests branch from d58facc to 7e0993d Compare June 29, 2024 07:06
@carsonbot carsonbot changed the title [FrameworkBundle][SecurityBundle] Compare paths after realpath() has been applied to both [SecurityBundle] Compare paths after realpath() has been applied to both Jun 29, 2024
@xabbuh xabbuh force-pushed the security-bundle-functional-tests branch from 7e0993d to 6ca2390 Compare June 29, 2024 09:25
@chalasr
Copy link
Member

chalasr commented Jun 29, 2024

Thank you @xabbuh.

@chalasr chalasr merged commit 4a48cfe into symfony:6.4 Jun 29, 2024
9 of 10 checks passed
@xabbuh xabbuh deleted the security-bundle-functional-tests branch June 29, 2024 09:50
@carsonbot carsonbot changed the title [SecurityBundle] Compare paths after realpath() has been applied to both [HttpKernel] Compare paths after realpath() has been applied to both Jul 5, 2024
This was referenced Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants