[String] Revert "Fixed u()->snake(), b()->snake() and s()->snake() methods" #57616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Jul 1, 2024
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jul 6, 2024
This PR was merged into the 5.4 branch. Discussion ---------- [String] test: kebab-case to snake_case | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes? | New feature? | no | Deprecations? | no | Issues | - | License | MIT In Symfony 7.1.1, `kebab-case` strings casted to `snake_case` properly. The changes made in 7.1.2 broke this functionality and kept it `kebab-case`. It would be nice to have a `kebab-case` test added to the list to clearly define the expected behavior. Relates to: #57497, #57612, #57616 Commits ------- a6d0f3b test: kebab-case to snake_case
|
This is still not correct or at least contains a BC break @nicolas-grekas I did not check whether this was introduced by the original change or your fix. The string New bug report? |
|
Better: a PR! 🙏 |
This was referenced Jul 26, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #57497 for BC reasons, but keeps the test cases we added in the process. Those test cases allowed to spot a real issue where the ascii and unicode implementations didn't agree on the resulting camel case for
SYMFONY IS GREAT. Both implementations now result inSYMFONYISGREAT(likely introduced in #47423).