Skip to content

[Lock] fix tests #57669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2024
Merged

[Lock] fix tests #57669

merged 1 commit into from
Jul 8, 2024

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 6, 2024 •
edited
Loading

Q A
Branch? 7.2
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

I didn't spot early enough that I broke the integration tests in #57665.

@carsonbot carsonbot added this to the 7.2 milestone Jul 6, 2024
@xabbuh xabbuh changed the title [Lock] fix tests [WIP][Lock] fix tests Jul 6, 2024
@xabbuh xabbuh force-pushed the pr-57665 branch 4 times, most recently from 76134de to 3eb613e Compare July 6, 2024 21:58
@xabbuh xabbuh requested a review from jderusse as a code owner July 6, 2024 21:58
@xabbuh xabbuh force-pushed the pr-57665 branch 5 times, most recently from 657ceb6 to bf6a0b2 Compare July 6, 2024 22:26
@xabbuh xabbuh changed the title [WIP][Lock] fix tests [Lock] fix tests Jul 6, 2024
@fabpot
Copy link
Member

fabpot commented Jul 8, 2024

Thank you @xabbuh.

@fabpot fabpot merged commit d87275c into symfony:7.2 Jul 8, 2024
8 of 10 checks passed
@xabbuh xabbuh deleted the pr-57665 branch July 8, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@jderusse jderusse Awaiting requested review from jderusse jderusse is a code owner

Assignees
No one assigned
Labels
Lock Status: Reviewed
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @fabpot @carsonbot