Code style change in @PER-CS2.0 affecting @Symfony (parentheses for anonymous classes)
#57901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@PER-CS2.0 affecting @Symfony (parentheses for anonymous classes)@PER-CS2.0 affecting @Symfony (parentheses for anonymous classes)
|
Would be fine by me 👍 |
derrabus
reviewed
Aug 1, 2024
derrabus
requested changes
Aug 5, 2024
derrabus
approved these changes
Aug 5, 2024
xabbuh
approved these changes
Aug 6, 2024
|
👍 from me as well |
…or anonymous classes)
|
Thank you @bonroyage. |
fabpot
added a commit
that referenced
this pull request
Aug 12, 2024
This PR was merged into the 7.2 branch. Discussion ---------- DX: simplify PHP CS Fixer config towards v3.62 | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Issues | no | License | MIT following #57901 Commits ------- 004818d DX: simplify PHP CS Fixer config towards v3.62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the
@PER-CS2.0ruleset in line with the specifications on thenew_with_parenthesesrule for anonymous classes. Since the@Symfonyruleset builds upon the@PER-CS2.0ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect@Symfony.Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.