-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[HttpFoundation] Add $requests
parameter to RequestStack
constructor
#57909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HttpFoundation] Add $requests
parameter to RequestStack
constructor
#57909
Conversation
dff1130
to
9af95a1
Compare
9af95a1
to
e16fd50
Compare
I was may a little bit to fast with refactor the symfony core tests as that would mean to increase the requirements for Still for reference: e16fd50 |
$requests
parameter to RequestStack
constructor
This looks like a reasonable change to me. Can you also add a changelog entry? |
The AppVeyor failing test seems to be unrelated to the change and happens currently als on 7.2 branch: https://ci.appveyor.com/project/fabpot/symfony/builds/50310250 |
d413641
to
7103295
Compare
Thank you @alexander-schranz. |
This change make it possible to directly give requests into the constructor. This way it make it easier to write Unit tests based on RequestStack like our own RequestAnalyzer service without the need to write the requestStack into an own variable e.g.
I updated also the Symfony core tests(Undo because lowest deps then not working still for reference e16fd50).The change in the
RequestStack
is:For BC reasons I did go of calling the
push
if somebody extending theRequestStack
.