[Translation] [Loco] Ability to configure value of status query-variable
#58072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
src/Symfony/Component/Translation/Bridge/Loco/Tests/LocoProviderTest.php
Outdated
Show resolved
Hide resolved
status query-variablestatus query-variable
status query-variablestatus query-variable
OskarStark
reviewed
Aug 23, 2024
src/Symfony/Component/Translation/Bridge/Loco/Tests/LocoProviderFactoryTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Translation/Bridge/Loco/Tests/LocoProviderTest.php
Outdated
Show resolved
Hide resolved
status query-variablestatus query-variable
nicolas-grekas
approved these changes
Aug 30, 2024
fabpot
approved these changes
Sep 1, 2024
|
Thank you @mathielen. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 11, 2024
…rYamous) This PR was merged into the 7.2 branch. Discussion ---------- [Translation] [Loco] Document `status` query variable | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | [Doc issue](symfony/symfony-docs#20184) - Related to #58072 | License | MIT Update readme for Loco bridge documentation Commits ------- 0a91018 add documentation for Loco query parameter
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to configure value of
statusquery-variable when fetching translations from loco API.With loco it is possible to flag your translations as
provisional, meaning that they might not be approved by someone in charge of your project's translations. For example these provisional translations might be auto-translated.To still be able to use these auto-translated translations in your project it must be possible to integrate them (i.e. via CLI command
bin/console translation:pull loco)Therefore, when invoking the export-API of loco a different value for the field
statushas to be given. Right now it is statically set totranslated,blank-translation, meaning provisional translations will not get fetched.With the DSN to the translation provider, we can already provide options to the translation provider implementation with query-parameters like this:
loco://API_KEY@default?status=translated,provisionalI have used this functionality for setting the desired value. By default (if omitted) the current value
translated,blank-translationwill be used.