Skip to content

make test case classes compatible with PHPUnit 10+ #58182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2024
Merged

make test case classes compatible with PHPUnit 10+ #58182

merged 1 commit into from
Sep 6, 2024

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Sep 5, 2024

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
Issues
License MIT

@carsonbot carsonbot added this to the 7.2 milestone Sep 5, 2024
GromNaN
GromNaN reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to add stubs to the bridge to resolve the missing class errors reported by psalm?

@xabbuh
Copy link
Member Author

xabbuh commented Sep 5, 2024

I think we can ignore them.

@derrabus
Copy link
Member

derrabus commented Sep 5, 2024

Currently we install PHPUnit 9.6 in our Psalm CI job. We might as well just bump that version.

OskarStark
OskarStark approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@fabpot
Copy link
Member

fabpot commented Sep 6, 2024

Thank you @xabbuh.

@fabpot fabpot merged commit 4973ab1 into symfony:7.2 Sep 6, 2024
8 of 10 checks passed
@fabpot fabpot mentioned this pull request Sep 6, 2024
Closed
@xabbuh xabbuh deleted the phpunit-test-case branch September 6, 2024 06:12
@fabpot fabpot mentioned this pull request Oct 27, 2024
Merged
@xabbuh xabbuh mentioned this pull request Nov 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN left review comments

@fabpot fabpot fabpot approved these changes

@stof stof stof approved these changes

@OskarStark OskarStark OskarStark approved these changes

@derrabus derrabus derrabus approved these changes

@welcoMattic welcoMattic Awaiting requested review from welcoMattic welcoMattic is a code owner

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Feature Status: Reviewed
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
7 participants
@xabbuh @derrabus @fabpot @GromNaN @stof @OskarStark @carsonbot