Skip to content

[Mailer][Webhook] Fix SendGrid Webhook parsing #58401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

kbond
Copy link
Member

@kbond kbond commented Sep 26, 2024

Q A
Branch? 7.2
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #58398
License MIT

Sendgrid sends multiple webhook events in a single request. Previously, only the first was parsed and the rest were silently ignored. This fix parses them all, but is only available on 7.2 because #58248 is required.

@carsonbot carsonbot added this to the 7.2 milestone Sep 26, 2024
@carsonbot carsonbot changed the title [WIP][Mailer] Fix SendGrid Webhook parsing [Mailer] [WIP] Fix SendGrid Webhook parsing Sep 26, 2024
@kbond kbond force-pushed the fix/sendgrid-webhook-parsing branch 2 times, most recently from 46b8432 to b68fc2c Compare September 26, 2024 17:28
@fabpot
Copy link
Member

fabpot commented Sep 27, 2024

@kbond #58248 has been merged now.

@kbond kbond force-pushed the fix/sendgrid-webhook-parsing branch 2 times, most recently from 88221b9 to 3887001 Compare September 27, 2024 11:00
@kbond kbond added the Webhook label Sep 27, 2024
@carsonbot carsonbot changed the title [Mailer] [WIP] Fix SendGrid Webhook parsing [Mailer][Webhook] [WIP] Fix SendGrid Webhook parsing Sep 27, 2024
@kbond kbond force-pushed the fix/sendgrid-webhook-parsing branch from 3887001 to abd76fc Compare September 27, 2024 12:23
@kbond kbond force-pushed the fix/sendgrid-webhook-parsing branch from abd76fc to 9ae908e Compare September 27, 2024 12:24
@kbond kbond changed the title [Mailer][Webhook] [WIP] Fix SendGrid Webhook parsing [Mailer][Webhook] Fix SendGrid Webhook parsing Sep 27, 2024
@fabpot
Copy link
Member

fabpot commented Sep 27, 2024

Thank you @kbond.

@fabpot fabpot merged commit e927511 into symfony:7.2 Sep 27, 2024
5 of 10 checks passed
@kbond kbond deleted the fix/sendgrid-webhook-parsing branch September 27, 2024 15:59
@fabpot fabpot mentioned this pull request Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SendgridRequestParser converts only the first event on the webhook
3 participants