Skip to content

[FrameworkBundle][Lock] Fix certain DSNs identified as service IDs #58445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2024
Merged

[FrameworkBundle][Lock] Fix certain DSNs identified as service IDs #58445

merged 1 commit into from
Oct 6, 2024

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Oct 3, 2024 •
edited
Loading

Q A
Branch? 7.2
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #58249 (comment)
License MIT

Follow up to #58249

The first PR introduced a BC break, as lock DSNs can also be in the following formats:

framework:
    lock: 'flock'
    lock: 'semaphore'
    lock: 'in-memory'

    lock: 'mysql:host=127.0.0.1;dbname=app'
    lock: 'pgsql:host=127.0.0.1;dbname=app'
    lock: 'pgsql+advisory:host=127.0.0.1;dbname=app'
    lock: 'sqlsrv:server=127.0.0.1;Database=app'
    lock: 'oci:host=127.0.0.1;dbname=app'

This PR introduces two changes:

  1. The framework bundle now treats any string containing a : as a DSN, instead of only those with ://
  2. flock, semaphore, and in-memory are now treated as special cases

@HypeMC HypeMC requested a review from jderusse as a code owner October 3, 2024 16:15
@carsonbot carsonbot added this to the 7.2 milestone Oct 3, 2024
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Oct 4, 2024 •
edited
Loading

Isn't this going to be super annoying, forcing everyone to update their config?
Can't we make these strings special instead?

@fabpot
Copy link
Member

fabpot commented Oct 6, 2024

Thank you @HypeMC.

@fabpot fabpot merged commit 478fbd6 into symfony:7.2 Oct 6, 2024
10 checks passed
@HypeMC HypeMC deleted the fix-lock-dsn branch October 6, 2024 10:12
@xabbuh xabbuh mentioned this pull request Oct 8, 2024
Closed
@HypeMC HypeMC mentioned this pull request Oct 10, 2024
Merged
nicolas-grekas added a commit that referenced this pull request Oct 23, 2024
@nicolas-grekas
bug #58518 [FrameworkBundle] Fix NullStore registration (HypeMC)
52a280e 
This PR was merged into the 7.2 branch.

Discussion
----------

[FrameworkBundle] Fix `NullStore` registration

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Follow up to #58109 and #58445, cc `@xabbuh`

I'm not sure if there's a way to get the XML config to work with the current schema as `null` is not interpreted as a string:

```xml
<framework:resource name="garply">null</framework:resource>
```

Commits
-------

cb528eb [FrameworkBundle] Fix `NullStore` registration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@jderusse jderusse Awaiting requested review from jderusse

Assignees
No one assigned
Labels
Bug FrameworkBundle Lock Status: Reviewed
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
4 participants
@HypeMC @nicolas-grekas @fabpot @carsonbot