Skip to content

[TwigBridge] Update main.css email stylesheet to latest foundation-emails release #58448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Conversation

phasdev
Copy link
Contributor

@phasdev phasdev commented Oct 3, 2024

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #58309
License MIT

Current email stylesheet (main.css) is outdated. Update v2.2.1 (released in 2016) to v2.4.0 (released in 2022) to get latest bug fixes, etc.

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Their changelog only lists bug fixes and a few new features: https://github.com/foundation/foundation-emails/releases/tag/v2.4.0

So, this seems free of BC breaks and could be safe to merge. Thanks!

@stof
Copy link
Member

stof commented Oct 4, 2024

hould we merge that in the 5.4 branch or only in 7.2 ?

@fabpot
Copy link
Member

fabpot commented Oct 6, 2024

I'd rather be on the safe side and merge in 7.2.

@fabpot fabpot modified the milestones: 5.4, 7.2 Oct 6, 2024
@fabpot fabpot changed the base branch from 5.4 to 7.2 October 6, 2024 09:00
@fabpot
Copy link
Member

fabpot commented Oct 6, 2024

Thank you @phasdev.

@fabpot fabpot merged commit 03c781a into symfony:7.2 Oct 6, 2024
9 of 10 checks passed
@OskarStark OskarStark changed the title [TwigBridge] Update main.css email stylesheet to latest foundation-emails release [TwigBridge] Update main.css email stylesheet to latest foundation-emails release Oct 7, 2024
@fabpot fabpot mentioned this pull request Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TwigBridge] Update main.css email stylesheet to latest foundation-emails release
5 participants