Skip to content

[TwigBridge] Update main.css email stylesheet to latest foundation-emails release #58310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9,983 commits into from
Closed

Conversation

phasdev
Copy link
Contributor

@phasdev phasdev commented Sep 18, 2024

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix 58309
License MIT

Current email stylesheet (main.css) is outdated. Update v2.2.1 (released in 2016) to v2.4.0 (released in 2022) to get latest bug fixes, etc.

xabbuh and others added 30 commits September 15, 2024 08:54
* 7.1:
  fix merge
  [Intl] Update ICU data from 74.1 to 75.1
  use DeprecatedCallableInfo for Twig callables if possible
  [Filesystem] Add a warning about `chown()` and `chgrp()` on Windows
  [String] Update wcswidth data with Unicode 16
  PhpSubprocess: Add flag PREG_OFFSET_CAPTURE to preg_match to identify the offset
  Work around parse_url() bug
  [Ldap] Clean `ldap_connect()` call in `LdapTestCase`
  [HttpFoundation] Update links for X-Accel-Redirect and fail properly when X-Accel-Mapping is missing
* 5.4:
  pass CSV escape characters explicitly
  move setting deprecation session options into a legacy group test
* 6.4:
  fix merge
  pass CSV escape characters explicitly
  move setting deprecation session options into a legacy group test
* 7.1:
  fix merge
  pass CSV escape characters explicitly
  move setting deprecation session options into a legacy group test
This PR was merged into the 7.1 branch.

Discussion
----------

[VarDumper] Fix `DOMCaster` test dumps

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

cc `@xabbuh`

Commits
-------

4201dde [VarDumper] Fix `DOMCaster` test dumps
* 7.1:
  [VarDumper] Fix `DOMCaster` test dumps
…exandre-daubois)

This PR was merged into the 7.2 branch.

Discussion
----------

[VarDumper] Fix dumping `ext-dom` virtual properties

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Fixes PHP 8.4 CI job.

Commits
-------

273f9cb [VarDumper] Fix dumping `ext-dom` virtual properties
This PR was submitted for the 7.1 branch but it was squashed and merged into the 7.2 branch instead.

Discussion
----------

[Process] Add Laravel Herd php detection path

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  |yes
| Deprecations? |no
| Issues        | –
| License       | MIT

As of right now, using the `PhpExecutableFinder` in combination with Laravel Herd, results in an empty string, which is what this PR fixes.

As the PhpExecutableFinder is already aware of XAMPP, it might be a good idea to also add support for Laravel Herd, which is widely used - not only in the Laravel ecosystem.

Laravel Herd uses statically compiled PHP binaries, which is why the `PHP_BINDIR` folder always points to `/bin` instead of a user-specific folder.

As Laravel Herd adds a `HERD_HOME` environment variable, we can check for the existence of this variable and then add the bin subdirectory to the list of directories to search.

I couldn't find any tests for XAMPP, which is why I haven't included any for this addition.

Commits
-------

93ca4e9 [Process] Add Laravel Herd php detection path
…aphore config (HypeMC)

This PR was merged into the 6.4 branch.

Discussion
----------

[FrameworkBundle] Finish incomplete tests for lock & semaphore config

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I noticed this while working on #58249. Basically, the test files were partially added but never used, so the tests were incomplete. ~Also, there's a bug in the schema, as the configuration in those files didn't work.~

Commits
-------

0574c86 [FrameworkBundle] Fix schema & finish incomplete tests for lock & semaphore config
…`UidNormalizer::NORMALIZATION_FORMAT_RFC9562` constants (alexandre-daubois)

This PR was merged into the 7.2 branch.

Discussion
----------

[Serializer][Uid] Add the `Uuid::FORMAT_RFC_9562` and `UidNormalizer::NORMALIZATION_FORMAT_RFC9562` constants

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Issues        | -
| License       | MIT

Following #58238 (cc `@fancyweb`), for completeness of this 7.2 feature.

Commits
-------

f84170a [Serializer][Uid] Add the `Uuid::FORMAT_RFC_9562` and `UidNormalizer::NORMALIZATION_FORMAT_RFC9562` constants
…m transport (ZhukV)

This PR was squashed before being merged into the 6.4 branch.

Discussion
----------

[Notifier][TurboSMS] Process partial accepted response from transport

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | None
| License       | MIT

TurboSMS can return `null` as message id, if sms not sent to recipient. Example:

```json
{
   "response_code": 802,
   "response_status": "SUCCESS_MESSAGE_PARTIAL_ACCEPTED",
   "response_result": [
      {
         "phone": "recipient_1",
         "response_code": 406,
         "message_id": null,
         "response_status": "NOT_ALLOWED_RECIPIENT_COUNTRY"
      },
      {
         "phone": "recipient_2",
         "response_code": 0,
         "message_id": "f83f8868-5e46-c6cf-e4fb-615e5a293754",
         "response_status": "OK"
      }
   ]
}
```

And we receive error:

```
Symfony\Component\Notifier\Message\SentMessage::setMessageId(): Argument #1 ($id) must be of type string, null given, called in /code/vendor/symfony/turbo-sms-notifier/TurboSmsTransport.php on line 93
```

Symfony use only one phone number for sent, as result we check only first `response_result`.

Commits
-------

932dbe3 [Notifier][TurboSMS] Process partial accepted response from transport
This PR was squashed before being merged into the 6.4 branch.

Discussion
----------

[Serializer] Fix for method named `get()`

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #58012
| License       | MIT

During normalization, if a class has a method called `get` that method will get confused for an accessor and it will go through logic relating to property-access for the property named `substr('get', 3)`.

Eventually a new PropertyPath instance will be created with an empty path which will trigger an exception.
```php
$serializer->serialize(new class {
    public function get() {}
}, 'json');
```

Commits
-------

a0d6e26 [Serializer] Fix for method named `get()`
…`, `use_trans_sid`, `trans_sid_hosts` and `trans_sid_tags` options to `NativeSessionStorage`
…ionStorage` (alexandre-daubois)

This PR was merged into the 7.2 branch.

Discussion
----------

[HttpFoundation] Deprecate more options in `NativeSessionStorage`

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | yes
| Issues        | -
| License       | MIT

Another round of deprecations for sessions. RFC for reference: https://wiki.php.net/rfc/deprecate-get-post-sessions#proposal

Commits
-------

60c1aae [HttpFoundation] Deprecate passing `referer_check`, `use_only_cookies`, `use_trans_sid`, `trans_sid_hosts` and `trans_sid_tags` options to `NativeSessionStorage`
* 5.4:
  [HttpClient] Fix setting CURLMOPT_MAXCONNECTS
  throw a meaningful exception when parsing dotenv files with BOM
  [Cache] Fix RedisSentinel params types
  [FrameworkBundle] Fix service reset between tests
  [Uid][Serializer][Validator] Mention RFC 9562
  make sure temp files can be cleaned up on Windows
…lint:container` command (ostrolucky)

This PR was merged into the 7.2 branch.

Discussion
----------

[FrameworkBundle] Add `--resolve-env-vars` option to `lint:container` command

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | yes
| Deprecations? |no
| Issues        | Fix #58105
| License       | MIT

Commits
-------

76bab40 [FrameworkBundle] Add --resolve-env-vars option to lint:container command
…session.sid_bits_per_character` config options (alexandre-daubois)

This PR was merged into the 7.2 branch.

Discussion
----------

[FrameworkBundle] Deprecate `session.sid_length` and `session.sid_bits_per_character` config options

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | yes
| Issues        | -
| License       | MIT

These options are (very) likely to be [deprecated in PHP 8.4](https://wiki.php.net/rfc/deprecations_php_8_4#sessionsid_length_and_sessionsid_bits_per_character). Because of the many reasons of their deprecation, they may be deprecated in Symfony as well starting the next version.

Commits
-------

0d2c231 [FrameworkBundle] Deprecate `session.sid_length` and `session.sid_bits_per_character` config options
* 6.4:
  [Serializer] Fix for method named `get()`
  [Notifier][TurboSMS] Process partial accepted response from transport
  [HttpClient] Fix setting CURLMOPT_MAXCONNECTS
  throw a meaningful exception when parsing dotenv files with BOM
  [FrameworkBundle] Fix schema & finish incomplete tests for lock & semaphore config
  [Cache] Fix RedisSentinel params types
  [FrameworkBundle] Fix service reset between tests
  [Uid][Serializer][Validator] Mention RFC 9562
  make sure temp files can be cleaned up on Windows
* 5.4:
  [Process] minor fix
  [Process] Fix finding executables independently of open_basedir
  [HttpKernel] Skip logging uncaught exceptions in ErrorHandler, assume $kernel->terminateWithException() will do it
  parse empty sequence elements as null
* 6.4:
  [Process] minor fix
  [Process] Fix finding executables independently of open_basedir
  [HttpKernel] Skip logging uncaught exceptions in ErrorHandler, assume $kernel->terminateWithException() will do it
  parse empty sequence elements as null
nicolas-grekas and others added 21 commits September 30, 2024 17:23
This PR was merged into the 7.2 branch.

Discussion
----------

[Mailer][Webhook] Mailtrap webhook support

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Issues        | n/a
| License       | MIT

Commits
-------

c79a984 [Mailer] add Mailtrap webhook support
…xandre-daubois)

This PR was merged into the 7.2 branch.

Discussion
----------

[String] Add the `AbstractString::kebab()` method

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Issues        | Fix #48780
| License       | MIT

Supersedes #48781. It seems there's quite a demand for this feature. I think it is a nice DX improvement which also helps readability over calling `snake()->replace('_', '-')`.

Commits
-------

b2b82d6 [String] Add the `AbstractString::kebab()` method
…ompute `kernel.secret` (nicolas-grekas)

This PR was merged into the 7.2 branch.

Discussion
----------

[FrameworkBundle] Never hash the empty decryption key to compute `kernel.secret`

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

As spotted by `@javiereguiluz` in symfony/demo#1529 (comment)

Commits
-------

b6d6bc1 [FrameworkBundle] Never hash the empty decryption key to compute kernel.secret
…rator (HypeMC)

This PR was merged into the 7.2 branch.

Discussion
----------

[ExpressionLanguage] Add support for logical `xor` operator

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Issues        | -
| License       | MIT

Contains #58342

Adds support for the logical `xor` operator.

Commits
-------

6e0a613 [ExpressionLanguage] Add support for logical `xor` operator
* 5.4:
  do not base services on PHPUnit mocks
  do not use TestCase::getName() when possible
  do not use assertCount() with generators
* 6.4:
  do not base services on PHPUnit mocks
  do not use TestCase::getName() when possible
  do not use assertCount() with generators
* 7.1:
  do not base services on PHPUnit mocks
  do not use TestCase::getName() when possible
  do not use assertCount() with generators
* 6.4:
  fix merge
  fix merge
* 7.1:
  fix merge
  fix merge
This PR was merged into the 7.2 branch.

Discussion
----------

Make ``@var`` occurrences consistent

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Both notation are indeed valid but given the number of occurrences, I suggest making the few "inverted" ones consistent with the rest of the whole codebase.

Commits
-------

4536275 Make ``@var`` occurrences consistent
This PR was merged into the 7.2 branch.

Discussion
----------

[Notifier][JoliNotif] Allow `jolicode/jolinotif` 3

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Issues        | none
| License       | MIT

Allow newly version of Jolinotif to be used with the Notifier. The current bridge already used the new architecture, so nothing to change here.

Commits
-------

c907a4a [Notifier] Allow Jolinotif v3
This PR was merged into the 7.2 branch.

Discussion
----------

Remove a few unnecessary full qualifier

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Remove full qualifier in places there are not present usually in the code base: mocks, already imported classes, expected exceptions.

Commits
-------

1543068 Remove a few unnecessary full qualifier
…r (Nico Hiort af Ornäs)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

[Notifier] [GatewayAPI] Add support for label parameter

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| License       | MIT

Add `label` parameter for GatewayAPI.

From the documentation:
```
label (string) - A label added to each sent message, which can be used to uniquely identify a customer or company that you have sent the message on behalf of. Can e.g. be used when invoicing your customers. If specified it must be the same for all messages in the request.
```

Commits
-------

67c136e [Notifier] [GatewayAPI] Add support for label parameter
…iles (danut007ro)

This PR was merged into the 7.2 branch.

Discussion
----------

[Translation] Allow sort when extracting translation files

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no
| Issues        | Fix #49250 #37918
| License       | MIT

This will keep current sorting when no `--sort` is specified.
- when dumping messages will sort `asc` by default
- when writing files will apply no sorting

Commits
-------

e517ce9 Fix git
@nicolas-grekas
Copy link
Member

Something is wrong with the history of this PR.
Can you please do something about it?
Note that PRs should not contain any merge commits. Please use git rebase instead.

alexandre-daubois and others added 3 commits October 3, 2024 12:53
…ois)

This PR was merged into the 7.2 branch.

Discussion
----------

[Mailer] Remove useless `sprintf()` call

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Commits
-------

61781dd [Mailer] Remove useless `sprintf()` call
@stof
Copy link
Member

stof commented Oct 3, 2024

this PR tries to merge the whole history of Symfony 7.2 into the 5.4 branch...

@phasdev
Copy link
Contributor Author

phasdev commented Oct 3, 2024

Sorry, my mistake. Here's what I think happened: I forked the Symfony repo and switched to the 5.4 branch where I made the bugfix. Then I used GitHub's Sync Fork feature to keep my bugfix branch in sync; this is what created the merge commits.
I mistakenly thought Sync Fork would sync the 5.4 branch but looks like it pulled in all the changes from the 7.2 branch.

I'll close this PR and create a new one with just the updated CSS file.

@phasdev phasdev closed this Oct 3, 2024
@phasdev phasdev deleted the fix_58309 branch October 3, 2024 16:43
@phasdev
Copy link
Contributor Author

phasdev commented Oct 3, 2024

OK, here's the updated PR: #58448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.