Skip to content

[WIP][POC] Run Windows tests on GitHub Action #58699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 32 commits into from
Closed

[WIP][POC] Run Windows tests on GitHub Action #58699

wants to merge 32 commits into from

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Oct 28, 2024

Q A
Branch? 7.2
Bug fix? no
New feature? no
Deprecations? No
Issues Relates to #58370
License MIT

@carsonbot carsonbot added this to the 7.2 milestone Oct 28, 2024
@wouterj wouterj changed the title [WIP] Run Windows tests on GitHub Action [WIP][POC] Run Windows tests on GitHub Action Oct 28, 2024
@wouterj wouterj force-pushed the phpunit11-windows-runner branch from be027db to d95cc5b Compare October 28, 2024 22:30
stof
stof reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the migration from Appveyor to GHA be decoupled from the migration to PHPUnit 11 ?

stof
stof reviewed Oct 30, 2024
View reviewed changes
@xabbuh
Copy link
Member

xabbuh commented Oct 30, 2024

@stof we can do the migration away from AppVeyor before updating to PHPUnit 11. Or somebody manages to find out why the AppVeyor job keeps failing on #58370 as I am out of ideas what's going wrong there.

@stof
Copy link
Member

stof commented Oct 30, 2024

for line ending failures, check the value of the core.autocrlf git config setting. Our contribution workflow expects that you use input (preserving existing newlines on checkout but converting CRLF to LF on commit) or false (no conversion at all). The value true (converting LF to CRLF on checkout so that your working directory uses windows line endings) is not compatible with our testsuite (as it means it runs a modified testsuite).

@stof
Copy link
Member

stof commented Oct 30, 2024

Searching the issue tracker of actions/checkout confirms that autocrlf is set to true by default on Windows (because this is the default config of git for windows). So you will need a step running git config --global core.autocrlf false before the actions/checkout step.

@xabbuh xabbuh mentioned this pull request Oct 30, 2024
Merged
@wouterj
Copy link
Member Author

wouterj commented Oct 30, 2024

Closing in favor of #58721

Thanks for the hints @stof, and rebasing these patches @xabbuh!

@wouterj wouterj closed this Oct 30, 2024
nicolas-grekas added a commit that referenced this pull request Nov 6, 2024
@nicolas-grekas
minor #58721 switch from AppVeyor to GitHub Actions to run tests on W…
2c7c4ba 
…indows (wouterj)

This PR was merged into the 5.4 branch.

Discussion
----------

switch from AppVeyor to GitHub Actions to run tests on Windows

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

In #58370 I tried hard but failed to get our test suite running with PHPUnit 11 on AppVeyor. `@wouterj` did a great job reviving an old branch and got it working on GitHub Actions in #58699. I picked his commit and rebased it on the `5.4` branch so that we are able to have a consistent CI config throughout all maintained branches.

Commits
-------

6f98b77 Port Appveyor to GitHub Actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@lyrixx lyrixx Awaiting requested review from lyrixx lyrixx is a code owner

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

@welcoMattic welcoMattic Awaiting requested review from welcoMattic welcoMattic is a code owner

@kbond kbond Awaiting requested review from kbond kbond is a code owner

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

@jderusse jderusse Awaiting requested review from jderusse jderusse is a code owner

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
5 participants
@wouterj @xabbuh @stof @carsonbot @staabm